Fix Content Only Toolbar icon focus style#64940
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
[Type] Bug
|
Size Change: -197 B (-0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Sep 9, 2024
Contributor
getdave
left a comment
getdave
left a comment
There was a problem hiding this comment.
In my testing the focus style was much better on this branch than on trunk.
ajlende
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes visual focus styles for the content only toolbar block icon.
Why?
Design and consistency.
How?
Remove old CSS that was adding unnecessary styles.
Testing Instructions
Test the block toolbar and content only block toolbar for regressions in visual styles for the block switcher/icon in both default and content only toolbars.
Testing Instructions for Keyboard
Screenshots or screencast
Before
After
