Site Logo: Fix loader alignment issue#64919
Merged
Conversation
akasunil
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Nice one! Seems safe to me, but if Ramon has a chance to look, would appreciate it! |
ramonjd
approved these changes
Sep 2, 2024
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Before
2024-09-02.12.53.43.mp4
After
2024-09-02.12.53.02.mp4
| { ( !! logoUrl || !! temporaryURL ) && logoImage } | ||
| { ! temporaryURL && ! logoUrl && ! canUserEdit && ( | ||
| <Placeholder className="site-logo_placeholder"> | ||
| { ( !! isLoading || |
Member
There was a problem hiding this comment.
I think isLoading would be a sufficient check as the value is already a boolean
| { ( !! isLoading || | ||
| ( ! temporaryURL && ! logoUrl && ! canUserEdit ) ) && ( | ||
| <Placeholder className="site-logo_placeholder" withIllustration> | ||
| { !! isLoading && ( |
Member
There was a problem hiding this comment.
Same here if you feel like changing, but optional as it's already in trunk.
Member
Author
There was a problem hiding this comment.
I have updated the condition. Thanks @ramonjd. Ill merge the PR now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Spinner alignment was off in
Site Logoblock when image is set and we reload the screen.Testing Instructions
Site LogoblockSite Logoblock, and Reload the pageScreenshots or screencast
|