Skip to content

Add text-shadow support to blocks via theme.json#63937

Open
madhusudhand wants to merge 1 commit intotrunkfrom
text-shadow/theme-json
Open

Add text-shadow support to blocks via theme.json#63937
madhusudhand wants to merge 1 commit intotrunkfrom
text-shadow/theme-json

Conversation

@madhusudhand
Copy link
Copy Markdown
Member

@madhusudhand madhusudhand commented Jul 25, 2024

What?

This change allows to set text shadow to blocks via theme.json typography definition.

image image

Testing Instructions

  1. In theme.json under typography settings of any block, set the new property textShadow to a valid shadow value.
  2. Shadow should be applied and visible in both editor and site frontend.

Related Issues:

This is a first iteration of #47904

@madhusudhand madhusudhand self-assigned this Jul 25, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 25, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@madhusudhand madhusudhand added [Type] Enhancement A suggestion for improvement. [Feature] Typography Font and typography-related issues and PRs labels Jul 25, 2024
@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Jul 26, 2024

I think text-shadow needs to be added to safecss_filter_attr() ?

@t-hamano t-hamano mentioned this pull request Jul 28, 2024
Open
6 tasks
@mikachan
Copy link
Copy Markdown
Member

mikachan commented Aug 22, 2024

Thanks @carolinan, do you know if that would be added in this file?

@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Aug 22, 2024

Thanks @carolinan, do you know if that would be added in this file?

Oh I did not know that existed, I am not sure if it should go in there or in lib/compat/version

@madhusudhand madhusudhand force-pushed the text-shadow/theme-json branch from 0e71b2b to dbd4728 Compare March 7, 2025 12:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2025

Flaky tests detected in dbd4728.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13721181607
📝 Reported issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tellthemachines tellthemachines Awaiting requested review from tellthemachines tellthemachines is a code owner

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego

At least 1 approving review is required to merge this pull request.

Assignees

@madhusudhand madhusudhand

Labels

[Feature] Typography Font and typography-related issues and PRs [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@madhusudhand @carolinan @mikachan