Skip to content

Site Editor: Improve author filter scaling for multiple authors - #63746

Closed
dhananjaykuber wants to merge 1 commit into
WordPress:trunkfrom
dhananjaykuber:update/data-view-filter-scale-for-authors
Closed

Site Editor: Improve author filter scaling for multiple authors#63746
dhananjaykuber wants to merge 1 commit into
WordPress:trunkfrom
dhananjaykuber:update/data-view-filter-scale-for-authors

Conversation

@dhananjaykuber

@dhananjaykuber dhananjaykuber commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

Fixes #63718

What?

This PR improves the scaling of author filters for pages in the Site Editor when multiple authors are present. It adjusts the placement of Filters and ViewActions components and updates related SCSS.

Why?

This PR addresses issue #63718, where the author filter design in the Site Editor doesn't scale well with 2+ authors. The current design becomes squished and difficult to read as more authors are added, with words sometimes appearing on a second line.

How?

The implementation involves:

  • Adjusting the placement of the Filters and ViewActions components to allow for better scaling.
  • Updating the SCSS to improve the layout and readability of the author filter interface.
  • Ensuring the design remains consistent and functional across various numbers of authors.

Testing Instructions

  • Open the Site Editor.
  • Navigate to the Pages section.
  • Attempt to filter pages by author.
  • Add multiple authors (2 or more) to the filter.
  • Observe that the filter interface scales properly, maintaining readability and proper layout.
  • Test with increasing numbers of authors to ensure the design remains functional and visually appealing.

Screenshots or screencast

Screen.Recording.2024-07-19.at.4.44.17.PM.mov

@github-actions

github-actions Bot commented Jul 19, 2024 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ryanwelcher ryanwelcher added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Jul 19, 2024
@jameskoster

jameskoster commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

The filter chip looks a little awkward when the content wraps. I wonder if we should set a max-width and truncate instead? Here's an old prototype to demonstrate.

@youknowriad

youknowriad commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Thanks a lot for tackling this, @dhananjaykuber! The filter-chip scaling problem has now been solved with a truncation approach in #83879, which closed #59696 (the issue #63718 was merged into). I'm going to close this as superseded.

@youknowriad youknowriad closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jameskoster jameskoster Awaiting requested review from jameskoster
@oandregal oandregal Awaiting requested review from oandregal oandregal is a code owner
@gigitux gigitux Awaiting requested review from gigitux gigitux is a code owner
@ntsekouras ntsekouras Awaiting requested review from ntsekouras ntsekouras is a code owner

Assignees

No one assigned

Labels

[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Data Views: filtering by author for pages doesn't scale with 2+ authors

4 participants

@dhananjaykuber @jameskoster @youknowriad @ryanwelcher