Term Description: Add border block support#63630
Merged
Conversation
akasunil
added
[Type] Enhancement
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for putting together this one @akasunil 👍
In general, the adoption of border support for the Term Description block works well for me.
✅ Global border styles for Term Description apply correctly
✅ Global border styles for the block display consistently between the frontend and editor
✅ Block instance border styles override the global border styles
✅ Block instance border styles apply consistently on frontend and in the editor
Screen.Recording.2024-07-17.at.4.27.36.PM.mp4
I did notice one minor issue though to do with the block not having box-sizing: border-box.
Screen.Recording.2024-07-17.at.4.35.01.PM.mp4
This issue wasn't introduced in this PR but it does make the issue more prominent.
Adding the box-sizing rule to the block's default styles should help address the issue.
P.S. Would you mind updating the test instructions to cover the interactions between Global Styles and the block support on block instances? It will help enable others to review these PRs 🙏
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +389 B (+0.02%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jul 18, 2024
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for iterating on this @akasunil 👍
Everything is looking good from my end now with the addition of the border-box box sizing.
Nice work!
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* Add border support to term description block * Add box sizing style to term description block Co-authored-by: akasunil <sunil25393@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
97 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Term Descriptionblock.Part of #43247
Why?
Term Descriptionblock is missing border support.How?
Adds the border block support in block.json
Testing Instructions
Term Descriptionblock's border is configurable via Global StylesTerm Descriptionblock and Apply the border stylesScreenshots or screencast
In backend:
In frontend: