Skip to content

Font Library: Include a "Select All" options to activate/deactivate all fonts #63531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 24, 2024
Merged

Font Library: Include a "Select All" options to activate/deactivate all fonts #63531

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2c60c90
Add function to activate all fonts on select all click
akasunil Jul 14, 2024
8acf978
implement toggle to select all fonts
akasunil Jul 14, 2024
5ea589c
add style for select all option
akasunil Jul 14, 2024
3033c2e
Add style for select all lable
akasunil Jul 14, 2024
1c2f346
Removed unneccessory use of flex component
akasunil Jul 15, 2024
23de4fb
Merge branch 'trunk' of personal.github.com:WordPress/gutenberg into …
akasunil Jul 17, 2024
e69d25f
Synced with trunk
akasunil Jul 20, 2024
7a1b78e
Remove new function added to context
akasunil Jul 20, 2024
ce0b3c1
Modified flow of select all toggle function
akasunil Jul 20, 2024
2c3fa28
Removed extra spaces
akasunil Jul 20, 2024
40bbb4b
Remove use of context
akasunil Jul 20, 2024
b0e227d
Update logic to choose all fonts on click in the indeterminate condition
akasunil Jul 20, 2024
f3681cb
Fix the issue of select all toggle for fonts without font faces
akasunil Jul 22, 2024
c923dff
Remove ad hoc font style for select all label
akasunil Jul 22, 2024
7c3a21b
Updated styles for select all toggle's checkbox to align with other c…
akasunil Jul 24, 2024
8d41f54
Synced with trunk and resolved conflicts
akasunil Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the issue of select all toggle for fonts without font faces
  • Loading branch information
@akasunil
akasunil committed Jul 22, 2024
commit f3681cbb08f8d631c1ee1a33b7698649b2762f46
10 changes: 6 additions & 4 deletions packages/edit-site/src/components/global-styles/font-library-modal/installed-fonts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,14 +164,16 @@ function InstalledFonts() {
).length
: 0;

const selectedFontsCount =
libraryFontSelected?.fontFace?.length ??
( libraryFontSelected?.fontFamily ? 1 : 0 );

// Check if any fonts are selected.
const isIndeterminate =
activeFontsCount > 0 &&
activeFontsCount !== libraryFontSelected?.fontFace?.length;
activeFontsCount > 0 && activeFontsCount !== selectedFontsCount;

// Check if all fonts are selected.
const isSelectAllChecked =
activeFontsCount === libraryFontSelected?.fontFace?.length;
const isSelectAllChecked = activeFontsCount === selectedFontsCount;

// Toggle select all fonts.
const toggleSelectAll = () => {
Expand Down