Skip to content

Issue template: use checkboxes instead of dropdown #63523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 14, 2024
Merged

Issue template: use checkboxes instead of dropdown #63523

merged 5 commits into from
Jul 14, 2024

Conversation

@ellatrix
Copy link
Member

@ellatrix ellatrix commented Jul 13, 2024 •
edited
Loading

What?

Also removes "multiple", it doesn't make sense at all to select both. I've also just left a checkbox for Yes.

Why?

It's super annoying to have to open a dropdown twice to be able to file a bug report.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix requested a review from desrosj as a code owner July 13, 2024 14:16
@github-actions
Copy link

github-actions bot commented Jul 13, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: alexstine <alexstine@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ellatrix ellatrix added the [Type] Project Management Meta-issues related to project management of Gutenberg label Jul 13, 2024
t-hamano
t-hamano reviewed Jul 13, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggested this problem in #51815.

To actually test the issue template, I created a test repository in my GitHub account.

The code from this PR is reflected here:
https://github.com/t-hamano/issue-template-test/issues/new?assignees=&labels=%5BType%5D+Bug&projects=&template=Bug_report.yml

.github/ISSUE_TEMPLATE/Bug_report.yml Outdated
- 'Yes'
- 'No'
- label: 'Yes'
validations:
Copy link
Contributor

@t-hamano t-hamano Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that if we want a checkbox to be required, we need to define it in the options field, not the validations field.

See this code sample: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms

Copy link
Member Author

@ellatrix ellatrix Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it should be good now. You can actually preview it here https://github.com/WordPress/gutenberg/blob/dc41b4fd10d6828f3985cffecfc52143d1011646/.github/ISSUE_TEMPLATE/Bug_report.yml

@t-hamano t-hamano linked an issue Jul 13, 2024 that may be closed by this pull request
ISSUE_TEMPLATE: Confirmation checks do not play a role #51815
Closed
@t-hamano t-hamano self-requested a review July 13, 2024 15:53
t-hamano
t-hamano approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just to be sure, I tested it in my repository and the validation for the checkboxes seems to work.

cea71fd54c538e2d06d879b56837bee6.mp4

alexstine
alexstine approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellatrix Awesome, makes this form so much nicer.

@ellatrix ellatrix enabled auto-merge (squash) July 14, 2024 19:44
@ellatrix ellatrix merged commit 6d37f9c into trunk Jul 14, 2024
@ellatrix ellatrix deleted the ellatrix-patch-1 branch July 14, 2024 20:01
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 14, 2024
scruffian pushed a commit that referenced this pull request Jul 15, 2024
@ellatrix @t-hamano @scruffian
Issue template: use checkboxes instead of dropdown (#63523)
8250d31 
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: alexstine <alexstine@git.wordpress.org>
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
@ellatrix @t-hamano @carstingaxion
Issue template: use checkboxes instead of dropdown (WordPress#63523)
dacaac2 
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: alexstine <alexstine@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexstine alexstine alexstine approved these changes

@t-hamano t-hamano t-hamano approved these changes

@desrosj desrosj Awaiting requested review from desrosj desrosj is a code owner

Assignees

No one assigned

Labels

[Type] Project Management Meta-issues related to project management of Gutenberg

Projects

None yet

Milestone

Gutenberg 18.9

Development

Successfully merging this pull request may close these issues.

ISSUE_TEMPLATE: Confirmation checks do not play a role

4 participants

@ellatrix @alexstine @t-hamano