Skip to content

Fix invalid css for nested fullwidth layouts with zero padding applied #63436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Fix invalid css for nested fullwidth layouts with zero padding applied #63436

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad8adcb
apply a default unit when set to zero (frontend)
richtabor Jul 11, 2024
60e53a2
apply a default unit when set to zero (editor)
richtabor Jul 11, 2024
b48a3c0
use 0 as a string
richtabor Jul 11, 2024
0f18b60
Fix linting issue
andrewserong Jul 16, 2024
f884c83
Add backport changelog entry
andrewserong Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
apply a default unit when set to zero (editor)
  • Loading branch information
@richtabor
richtabor committed Jul 11, 2024
commit 60e53a2cbf2cc861c1a1d78e22ec147d5792f641
12 changes: 10 additions & 2 deletions packages/block-editor/src/layouts/constrained.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,15 +234,23 @@ export default {
const paddingValues = getCSSRules( style );
paddingValues.forEach( ( rule ) => {
if ( rule.key === 'paddingRight' ) {
// Add unit if 0, to avoid calc(0 * -1) which is invalid.
const paddingRightValue =
rule.value === '0' ? '0px' : rule.value;

output += `
${ appendSelectors( selector, '> .alignfull' ) } {
margin-right: calc(${ rule.value } * -1);
margin-right: calc(${ paddingRightValue } * -1);
}
`;
} else if ( rule.key === 'paddingLeft' ) {
// Add unit if 0, to avoid calc(0 * -1) which is invalid.
const paddingLeftValue =
rule.value === '0' ? '0px' : rule.value;

output += `
${ appendSelectors( selector, '> .alignfull' ) } {
margin-left: calc(${ rule.value } * -1);
margin-left: calc(${ paddingLeftValue } * -1);
}
`;
}
Expand Down