Skip to content

Keep default padding on nested sub-menus#62749

Open
graylaurenm wants to merge 1 commit intoWordPress:trunkfrom
graylaurenm:navigation-block-submenu-padding
Open

Keep default padding on nested sub-menus#62749
graylaurenm wants to merge 1 commit intoWordPress:trunkfrom
graylaurenm:navigation-block-submenu-padding

Conversation

@graylaurenm
Copy link
Copy Markdown
Contributor

What?

Modifies the selector that manages submenu padding.

Why?

Nested submenus are missing necessary padding to visually align with other menu items.

How?

Changes the selector to only target top-level submenus.

Testing Instructions

Create a navigation block:
Level 1

  • Level 2 (A)
    • Level 3
  • Level 2 (B)

Notice how "Level 2 (A)" has no padding-left while "Level 2 (B)" does.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

Before:
Screenshot 2024-06-21 at 9 24 29 AM

After:
Screenshot 2024-06-21 at 9 24 15 AM

@graylaurenm graylaurenm requested a review from ajitbohra as a code owner June 21, 2024 13:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 21, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: [Package] Block library, First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: graylaurenm <oncecoupled@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @graylaurenm! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 21, 2024
@akasunil akasunil added the [Package] Block library /packages/block-library label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block library /packages/block-library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants