Skip to content

Button Block: Allow custom width - #62280

Closed
prasadkarmalkar wants to merge 1 commit into
WordPress:trunkfrom
prasadkarmalkar:feat/button-block-allow-custom-width
Closed

prasadkarmalkar wants to merge 1 commit into
WordPress:trunkfrom
prasadkarmalkar:feat/button-block-allow-custom-width

Conversation

@prasadkarmalkar

@prasadkarmalkar prasadkarmalkar commented Jun 4, 2024 •

Copy link
Copy Markdown
Contributor

Closes: #62247

What?

Add FontSizePicker for button block for custom width size

Why?

To allow custom width for button block

How?

We are using the FontSizePicker for width of the button so that we can choose the custom size as well. And instead of giving width using class we are using the style attribute.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2024-06-04 at 5 20 33 PM Screenshot 2024-06-04 at 5 25 30 PM

@github-actions

github-actions Bot commented Jun 4, 2024 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 4, 2024
@github-actions

github-actions Bot commented Jun 4, 2024

Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @prasadkarmalkar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@amitraj2203 amitraj2203 added [Type] Enhancement A suggestion for improvement. [Block] Buttons Affects the Buttons Block labels Jun 8, 2024
@mirka

mirka commented Aug 7, 2024

Copy link
Copy Markdown
Member

Thank you for contributing! 🙌

Please see #62247 (comment) for a suggestion to use a more standard mechanism for this.

@skorasaurus

Copy link
Copy Markdown
Member

thanks for your effort although allowing custom width of the button block is now already implemented in #74242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Buttons Affects the Buttons Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button Block: Allow custom width

4 participants