Add: Content panel for template parts.#62034
Merged
jorgefilipecosta merged 1 commit intotrunkfrom Jun 18, 2024
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +105 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/content-panel-for-template-parts
branch
from
9a83972 to
3d8c42e
Compare
jorgefilipecosta
added
[Type] Enhancement
Contributor
|
Nice one. I'm not seeing the panel show up for me, though, am I doing something wrong? |
Member
Author
|
Hi @jasmussen, it seems you opened a template and not a template part, for this to appear you need to open a template part directly in the editor (e.g: go to patterns, header, and open a header template part), it appears under the "Template part" tab, not the block one. |
jasmussen
approved these changes
Jun 18, 2024
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Works as advertised, good improvement. Could use a code review. Before:
After:
Your explanation of what I did wrong makes sense, however it does suggest that what exists on the editor for the individual template part could exist on the block tab for a template part as well. Both because that block tab is currently empty:
But also because there's precedence for this content panel in the block tab, with contentOnly patterns, and synced pattern overrides as well.
Member
Author
Sure, let me try in a follow-up to add a content panel there 😊 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a content panel for template parts whose mockup is available here #59689 (comment).
Blocks that appear on the content area of template parts are the blocks whose category is 'theme'.
Testing Instructions
I opened some template parts and verified they included a content panel.
Screenshots or screencast