Fix the removePropertyFromObject function throws an error if the object is null#60831
Merged
fabiankaegy merged 2 commits intotrunkfrom Apr 17, 2024
Merged
Fix the removePropertyFromObject function throws an error if the object is null#60831fabiankaegy merged 2 commits intotrunkfrom
fabiankaegy merged 2 commits intotrunkfrom
Conversation
…the styles of the split border
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
arthur791004
added
the
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
fabiankaegy
approved these changes
Apr 17, 2024
Member
fabiankaegy
left a comment
fabiankaegy
left a comment
There was a problem hiding this comment.
This works as advertised 👍 Thanks for the fix
arthur791004
added a commit
that referenced
this pull request
Apr 18, 2024
…ct is null (#60831) Co-authored-by: arthur791004 <arthur791004@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
colorful-tones
added
[Package] Edit Site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Prevent the
removePropertyFromObjectfrom throwing an error if the object is null.Why?
Fixes #60830.
How?
Return early before calling the
Object.keysfunction if the object is nullTesting Instructions
Styles > BlocksUnlink sidesicon to split the borderStyles > TypographyorStyles > ColorsTesting Instructions for Keyboard
Screenshots or screencast