Removed pointer-events none inline style due it blocking crop action#60305
Merged
michalczaplinski merged 1 commit intoWordPress:trunkfrom Apr 2, 2024
Conversation
n2erjo00
requested review from
artemiomorales and
michalczaplinski
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
michalczaplinski
added
[Type] Bug
michalczaplinski
approved these changes
Apr 2, 2024
Contributor
There was a problem hiding this comment.
This makes sense to me. I've tested it and it fixes the issue 🙂 .
Thank you for the fix @n2erjo00 !
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…ordPress#60305) Co-authored-by: n2erjo00 <n2erjo00@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org> Co-authored-by: MadtownLems <madtownlems@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In the block editor using Image block if image has a link it is impossible to use crop action. This PR fixes that issue.
Why?
Closes #60081
How?
When editor adds
<a>tag around the image, the link has inline styles. One of those styles ispointer-events: nonewhich will block all actions related directly to link and all its children. This PR removes that style because it creates the issue and it is redundant since<a>already hasonClickhandler which prevents user from triggering link actionTesting Instructions
Also linked issue contains really good documentation how the issue can be replicated.
Testing Instructions for Keyboard
Screenshots or screencast