Update overlay step function in cover block by akasunil · Pull Request #59891 · WordPress/gutenberg

akasunil · 2024-03-15T06:53:16Z

What?

Fixes #51625

Why?

Currently, we can set overlay in multiple of 10 in cover block.

How?

I have updated steps to enable any number from 1 to 100 to be set as overlay value.

Testing Instructions

Add cover block
Change overlay
Notice opacity

Screenshots or screencast

github-actions · 2024-03-15T06:53:31Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: stokesman <presstoke@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: ndiego <ndiego@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: hanneslsm <hanneslsm@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

… fix-issue-51625

akasunil · 2024-04-23T14:00:46Z

Hi @Mamaduka, need your help with PR review here.

Mamaduka · 2024-04-30T11:37:36Z

Hi, @sunil25393

It's been a while since I worked on the Cover block, and I might miss some of the pre-requestions needed for this change. I would recommend contacting folks who worked on the overlay feature "recently". cc @t-hamano, @stokesman

P.S. Removing the has-background-dim-{unit} class can be considered a breaking change, though I don't have any data about their usage in real-world sites.

akasunil · 2024-05-01T04:55:34Z

Removing the has-background-dim-{unit} class can be considered a breaking change,

I have kept the css for backward compatibility. We can deprecate it in future version of gutenberg i guess.

stokesman · 2024-05-03T23:27:38Z

I have kept the css for backward compatibility.

Yes but George was referring to its corresponding class in the markup. There could be instances of CSS written using it in their selectors. Here’s what can be found in themes from wpdirectory. Most of the usage seems odd to me and I'd like to think we can not worry about breakage but I think that’d be against policy.

Otherwise, I gave this a test drive and it worked well. I only tested a basic Cover block created from trunk before switching to this branch and the block updates successfully. I'm not sure how else these types of changes need to be tested.

akasunil · 2024-05-04T05:21:38Z

There could be instances of CSS written using it in their selectors.

Thank you for your reply. I see it now. However, if we leave the class selectors, opacity will be applied twice. There is no significance to it. Is there a workaround for this? We can always update the changelog, though.

stokesman · 2024-05-07T21:04:58Z

I took a closer look at the selectors used in the themes from that search and all of them that I saw are written for older cover block versions which had the has-background-dim-{unit} class directly on the block’s root element. So those styles wouldn’t be applying to more recent cover block versions anyway. I.e. this change won’t break those styles.

Yet I didn’t examine all the results because they are many (though it appears they are all repetitions of what I did examine). I wanted to try a more exacting regex to find results that aren’t paired up with wp-cover-block classes but didn’t see a way to do it that’s supported by WP Directory’s regex interpreter.

I've also ran the search on plugins. There are some results though it appears that they are for custom blocks that adopted the use of the class and so should be unaffected by this change. For example, I tested the most installed plugin in the results (WooCommerce) and the class is used on their Featured Product block that has nothing to do with Cover.

My feeling is that this should be safe to ship as is but I don’t know the level of caution others might think is warranted.

akasunil · 2024-05-10T04:42:07Z

Thank you for investing @stokesman, @t-hamano can we get your view on this ?

akasunil · 2024-06-17T07:01:49Z

@WordPress/outreach Need this PR to be reviewed.

…ix-issue-51625

carolinan · 2024-06-27T09:21:46Z

Hi @akasunil You need to update the PR with the latest files from Gutenberg trunk, and make sure that the tests pass.

carolinan · 2024-06-27T09:23:22Z

Change to 6.5 compatibility files need to be moved, I assume since we are in RC already, this needs to be in a 6.7 compatibility file, not 6.6.

…ix-issue-51625

akasunil · 2024-06-29T07:55:04Z

Hi @carolinan, I have updated PR. Could use review.

Original PR from Gutenberg repository: * [WordPress/gutenberg#59891 #59891 Update overlay step function in cover block] Reference: [https://developer.mozilla.org/en-US/docs/Web/CSS/opacity MDN Web Docs: opacity]. Props sunil25393, wildworks, poena, Mamaduka, presstoke. Fixes #61536. git-svn-id: https://develop.svn.wordpress.org/trunk@58709 602fd350-edb4-49c9-b593-d223f7449a82

Original PR from Gutenberg repository: * [WordPress/gutenberg#59891 #59891 Update overlay step function in cover block] Reference: [https://developer.mozilla.org/en-US/docs/Web/CSS/opacity MDN Web Docs: opacity]. Props sunil25393, wildworks, poena, Mamaduka, presstoke. Fixes #61536. Built from https://develop.svn.wordpress.org/trunk@58709 git-svn-id: http://core.svn.wordpress.org/trunk@58111 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Original PR from Gutenberg repository: * [WordPress/gutenberg#59891 #59891 Update overlay step function in cover block] Reference: [https://developer.mozilla.org/en-US/docs/Web/CSS/opacity MDN Web Docs: opacity]. Props sunil25393, wildworks, poena, Mamaduka, presstoke. Fixes #61536. Built from https://develop.svn.wordpress.org/trunk@58709 git-svn-id: https://core.svn.wordpress.org/trunk@58111 1a063a9b-81f0-0310-95a4-ce76da25c4cd

aaronrobertshaw

Thank you for all the hard work on this PR @akasunil 👍

I'm still in the process of giving the code a thorough review and test but thought it important to share a few early thoughts.

Backwards Compatibilty

As has already been discussed on this PR, the removal of the dim ratio CSS class from the block will cause existing blocks to be flagged as invalid due to the saved markup no longer matching what is generated in the editor.

If the dim ratio CSS class is to be removed in favour of an inline opacitiy style, the Cover block will need a deprecation to migrate the old versions' markup.

A lot of the block fixtures that are updated in this PR are related to past deprecations. Changing them means they don't match the markup those deprecated versions of the block actually have so are now incorrect.

The non-__deprecated fixtures could be updated with the proposed inline opacity styles but we would also need new fixtures covering the deprecation of the dim ratio class.

Alternative Approach

There are also a number of open issues currently to update the Cover block such that it's overlay is configurable via theme.json and Global Styles. The primary issue for this is:

#27809

The general idea is that the background color block support could be used to provide the color for a Cover block's overlay. This block support also allows defining opactity via the color's alpha channel.

It's been on my radar for a while but I haven't had the bandwidth in the lead up to 6.6 to explore too deeply. I believe @ramonjd has also started working on this too.

I'm not sure yet whether the UI for the Cover block's overlay opacity would be removed so we rely solely on the background color control or whether it would be left in place as a convenience until it can be deprecated.

With the release of the Section Styles feature, the ability to style the Cover block's overlay via theme.json is getting more attention. I'd go so far as to say it's a must-have. (cc/ @richtabor)

As this PR won't address the above need and the alternative approach would also solve the main concern this PR addresses (i.e. finer control over opacity). I'd like to propose we avoid introducing the inline opacity style which would require yet another deprecation once the overlay is switched to use the background color block support.

I really do appreciate the huge amount of work that has gone into this PR. FWIW it might still help inform the direction we ultimately go in.

If you are open to it, perhaps we can collaborate on the alternative approach?

ndiego · 2024-07-16T11:58:41Z

With the release of the #57908 feature, the ability to style the Cover block's overlay via theme.json is getting more attention. I'd go so far as to say it's a must-have.

Agreed.

richtabor · 2024-07-17T19:27:58Z

As this PR won't address the above need and the alternative approach would also solve the may concern this PR addresses (i.e. finer control over opacity). I'd like to propose we avoid introducing the inline opacity style which would require yet another deprecation once the overlay is switched to use the background color block support.

I tend to agree. With this effort in flux yet I don't think we should push forward on too many changes with the opacity control. I think perhaps it coexists, but I'd like to push that work forward first.

Original PR from Gutenberg repository: * [WordPress/gutenberg#59891 #59891 Update overlay step function in cover block] Reference: [https://developer.mozilla.org/en-US/docs/Web/CSS/opacity MDN Web Docs: opacity]. Props sunil25393, wildworks, poena, Mamaduka, presstoke. Fixes #61536. git-svn-id: https://develop.svn.wordpress.org/trunk@58709 602fd350-edb4-49c9-b593-d223f7449a82

akasunil · 2024-07-21T06:27:23Z

Thank you for the detailed feedback on this PR. I appreciate the time you're putting into reviewing.

I agree that we should minimize the deprecation as much possible, If we have better way to improve functionality, we should discuss that. Coming to the alternative approach you proposed, which involves updating the Cover block such that its overlay is configurable via theme.json and Global Styles, is definitely better solution then the inline styles this PR add into block.

The general idea is that the background color block support could be used to provide the color for a Cover block's overlay.

Just for the clarity, Does it mean we add a new setting for overlay color under block color support?

I'm open to collaborate on the alternative approach. It sounds like a more flexible solution for the Cover block's styling capabilities.

I really do appreciate the huge amount of work that has gone into this PR. FWIW it might still help inform the direction we ultimately go in.

Thank you again for your valuable insights and for recognizing the work put into this PR.

aaronrobertshaw · 2024-07-21T12:20:31Z

Just for the clarity, Does it mean we add a new setting for overlay color under block color support?

Ideally, we'd reuse the background color support as is, if possible. From the UI side, I think the difficulty would be labelling the "background" control as "overlay" so its purpose is still clear.

I'm open to collaborate on the alternative approach.

That sounds great, thanks 👍

As that work progresses, I'll add you to any issues and PRs as they're created.

richtabor · 2024-07-21T16:56:19Z

Ideally, we'd reuse the background color support as is, if possible. From the UI side, I think the difficulty would be labelling the "background" control as "overlay" so its purpose is still clear.

It's probably fine with the first iteration to just use "Background" even. There's a few ideas floating around about consolidating background color and image into one PanelBody, it may be that we don't need to change the label if that's the case.

ramonjd · 2024-07-22T00:05:40Z

I believe @ramonjd has also started working on this too.

Nothing recently, but it's worth highlighting the proposal to merge background controls in the UI.

#63096

#60100 (comment)

This wouldn't affect the way the background values are read and stored in theme.json, but would eventually make controls consistent across blocks that have background image and background color supports enabled, the Cover block (hopefully one day) included.

Original PR from Gutenberg repository: * [WordPress/gutenberg#59891 #59891 Update overlay step function in cover block] Reference: [https://developer.mozilla.org/en-US/docs/Web/CSS/opacity MDN Web Docs: opacity]. Props sunil25393, wildworks, poena, Mamaduka, presstoke. Fixes #61536. git-svn-id: https://develop.svn.wordpress.org/trunk@58709 602fd350-edb4-49c9-b593-d223f7449a82

@SInCE

* WP-r55564: KSES: Allow `filter` property to accept a URL in `safecss_filter_attr()`. CSS filters can accept `url()` as a reference to an SVG filter element: {{{ filter: url( file.svg#filter-element-id ); }}} This commit allows for that syntax to be used in inline CSS. Original PR from Gutenberg repository: * [WordPress/gutenberg#48281 https://core.trac.wordpress.org/ticket/48281 Duotone: Use the style engine to generate CSS for Duotone] References: * [https://developer.mozilla.org/en-US/docs/Web/CSS/filter MDN Web Docs: filter()] * [https://developer.mozilla.org/en-US/docs/Web/CSS/url MDN Web Docs: url()] Follow-up to https://core.trac.wordpress.org/changeset/44136, https://core.trac.wordpress.org/changeset/52049. WP:Props scruffian, jeryj, ironprogrammer, azaozz, hellofromTonya, SergeyBiryukov. Fixes https://core.trac.wordpress.org/ticket/57780. --- Merges https://core.trac.wordpress.org/changeset/55564 / WordPress/wordpress-develop@6d1381180b to ClassicPress. * WP-r55642: Coding Standards: Use strict comparison where `count()` is involved. Follow-up to https://core.trac.wordpress.org/changeset/1636, https://core.trac.wordpress.org/changeset/6974, https://core.trac.wordpress.org/changeset/8114, https://core.trac.wordpress.org/changeset/10322, https://core.trac.wordpress.org/changeset/13326, https://core.trac.wordpress.org/changeset/14760, https://core.trac.wordpress.org/changeset/18006, https://core.trac.wordpress.org/changeset/18541, https://core.trac.wordpress.org/changeset/19743, https://core.trac.wordpress.org/changeset/23249, https://core.trac.wordpress.org/changeset/24115, https://core.trac.wordpress.org/changeset/33359. WP:Props aristath, poena, afercia, SergeyBiryukov. See https://core.trac.wordpress.org/ticket/57839. --- Merges https://core.trac.wordpress.org/changeset/55642 / WordPress/wordpress-develop@81598dd34f to ClassicPress. * WP-r55652: Coding Standards: Use strict comparison where `strlen()` is involved. Follow-up to https://core.trac.wordpress.org/changeset/649, https://core.trac.wordpress.org/changeset/1345, https://core.trac.wordpress.org/changeset/3034, https://core.trac.wordpress.org/changeset/6132, https://core.trac.wordpress.org/changeset/6314, https://core.trac.wordpress.org/changeset/6974, https://core.trac.wordpress.org/changeset/55642. WP:Props aristath, poena, afercia, SergeyBiryukov. See https://core.trac.wordpress.org/ticket/57839. Conflicts: - src/wp-includes/load.php --- Merges https://core.trac.wordpress.org/changeset/55652 / WordPress/wordpress-develop@760728c92f to ClassicPress. * Fix merge conflict from 55652 * WP-r55677: Coding Standards: Use strict comparison where `strtolower()` is involved. Follow-up to https://core.trac.wordpress.org/changeset/649, https://core.trac.wordpress.org/changeset/7736, https://core.trac.wordpress.org/changeset/18821, https://core.trac.wordpress.org/changeset/19444, https://core.trac.wordpress.org/changeset/20886, https://core.trac.wordpress.org/changeset/20893, https://core.trac.wordpress.org/changeset/23303, https://core.trac.wordpress.org/changeset/55642, https://core.trac.wordpress.org/changeset/55652, https://core.trac.wordpress.org/changeset/55653, https://core.trac.wordpress.org/changeset/55654. WP:Props aristath, poena, afercia, SergeyBiryukov. See https://core.trac.wordpress.org/ticket/57839. Conflicts: - src/wp-includes/theme.php --- Merges https://core.trac.wordpress.org/changeset/55677 / WordPress/wordpress-develop@c2f262971c to ClassicPress. * Fix merge conflicts from 55677 * WP-r55703: Code Modernization: Replace usage of `strpos()` with `str_starts_with()`. `str_starts_with()` was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle). WordPress core includes a polyfill for `str_starts_with()` on PHP < 8.0 as of WordPress 5.9. This commit replaces `0 === strpos( ... )` with `str_starts_with()` in core files, making the code more readable and consistent, as well as improving performance. While `strpos()` is slightly faster than the polyfill on PHP < 8.0, `str_starts_with()` is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle. Follow-up to https://core.trac.wordpress.org/changeset/52039, https://core.trac.wordpress.org/changeset/52040, https://core.trac.wordpress.org/changeset/52326. WP:Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov. Fixes https://core.trac.wordpress.org/ticket/58012. Conflicts: - src/wp-admin/includes/class-wp-privacy-policy-content.php - src/wp-admin/includes/credits.php - src/wp-admin/includes/post.php - src/wp-admin/includes/privacy-tools.php - src/wp-admin/load-styles.php - src/wp-admin/menu-header.php - src/wp-includes/block-template.php - src/wp-includes/blocks.php - src/wp-includes/bookmark-template.php - src/wp-includes/class-simplepie.php - src/wp-includes/l10n.php - src/wp-includes/pluggable.php - src/wp-includes/post-template.php - src/wp-includes/script-loader.php - src/wp-includes/widgets/class-wp-widget-block.php --- Merges https://core.trac.wordpress.org/changeset/55703 / WordPress/wordpress-develop@4cb3e1582a to ClassicPress. * WP-r55822: General: Use `static` on closures whenever `$this` is not used to avoid memory leaks. WP:Props westonruter, jrf, spacedmonkey. Fixes https://core.trac.wordpress.org/ticket/58323. Conflicts: - src/wp-admin/includes/file.php - src/wp-includes/blocks.php - src/wp-includes/kses.php - src/wp-includes/script-loader.php - tests/performance/wp-content/mu-plugins/server-timing.php - tests/phpunit/tests/admin/wpSiteHealth.php - tests/phpunit/tests/blocks/editor.php - tests/phpunit/tests/blocks/renderCommentTemplate.php - tests/phpunit/tests/blocks/wpBlock.php - tests/phpunit/tests/dependencies/scripts.php - tests/phpunit/tests/media.php - tests/phpunit/tests/rest-api/rest-server.php - tests/phpunit/tests/rest-api/rest-themes-controller.php - tests/phpunit/tests/theme/wpThemeJsonResolver.php --- Merges https://core.trac.wordpress.org/changeset/55822 / WordPress/wordpress-develop@d5792c7a88 to ClassicPress. * WP-r55937: Formatting: Support aria content attributes. Add `aria-controls`, `aria-expanded`, and `aria-current` to allowed attributes in KSES. WP:Props crs1138, rsiddharth, mukesh27, SergeyBiryukov, joedolson, ryokuhi, peterwilsoncc, audrasjb, nataliat2004. Fixes https://core.trac.wordpress.org/ticket/55370. Conflicts: - src/wp-includes/kses.php --- Merges https://core.trac.wordpress.org/changeset/55937 / WordPress/wordpress-develop@1e090291f0 to ClassicPress. * WP-r55944: KSES: Add support for CSS `repeat()` function. Introduces support for the CSS `repeat()` function to support complex grid layouts. WP:Props isabel_brison, azaozz. Fixes https://core.trac.wordpress.org/ticket/58551. Conflicts: - tests/phpunit/tests/kses.php --- Merges https://core.trac.wordpress.org/changeset/55944 / WordPress/wordpress-develop@2b7f865417 to ClassicPress. * Fix merge conflict from 55944 * WP-r56046: Editor: add box shadow support to blocks. Adds the ability for blocks to declare support for CSS box-shadow and processing of necessary styles. WP:Props madhudollu, sabernhardt, ramonopoly, spacedmonkey, mukesh27. Fixes https://core.trac.wordpress.org/ticket/58590. Conflicts: - src/wp-includes/style-engine/class-wp-style-engine.php - src/wp-settings.php - tests/phpunit/tests/style-engine/styleEngine.php --- Merges https://core.trac.wordpress.org/changeset/56046 / WordPress/wordpress-develop@e55e9c2f0c to ClassicPress. * Fix merge conflict from 56046 * WP-r56191: Docs: Replace multiple single line comments with multi-line comments. This changeset updates various comments as per WordPress PHP Inline Documentation Standards. See https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/https://core.trac.wordpress.org/ticket/5-inline-comments. Follow-up to https://core.trac.wordpress.org/changeset/56174, https://core.trac.wordpress.org/changeset/56175, https://core.trac.wordpress.org/changeset/56176, https://core.trac.wordpress.org/changeset/56177, https://core.trac.wordpress.org/changeset/56178, https://core.trac.wordpress.org/changeset/56179, https://core.trac.wordpress.org/changeset/56180. WP:Props costdev, audrasjb. See https://core.trac.wordpress.org/ticket/58459. Conflicts: - src/wp-includes/media.php --- Merges https://core.trac.wordpress.org/changeset/56191 / WordPress/wordpress-develop@3666c0e31b to ClassicPress. * Fix merge conflict from 56191 * WP-r56377: Coding Standards: Use strict comparison in `wp-includes/kses.php`. Follow-up to https://core.trac.wordpress.org/changeset/649, https://core.trac.wordpress.org/changeset/2896, https://core.trac.wordpress.org/changeset/3418, https://core.trac.wordpress.org/changeset/8386, https://core.trac.wordpress.org/changeset/20540, https://core.trac.wordpress.org/changeset/47219, https://core.trac.wordpress.org/changeset/54933. WP:Props aristath, poena, afercia, SergeyBiryukov. See https://core.trac.wordpress.org/ticket/58831. --- Merges https://core.trac.wordpress.org/changeset/56377 / WordPress/wordpress-develop@b1d59267af to ClassicPress. * Manual cherry-pick of 56559 * WP-r56608: Docs: Document `aria-live` and `hidden` in `safecss_filter_attr()`. In https://core.trac.wordpress.org/changeset/56603, support was added for `aria-live` and `hidden` attributes in `safecss_filter_attr()`. This adds a `@since` annotation to document this change. Follow-up to https://core.trac.wordpress.org/changeset/56603. WP:Props mukesh27. See https://core.trac.wordpress.org/ticket/57791. --- Merges https://core.trac.wordpress.org/changeset/56608 / WordPress/wordpress-develop@a7c9394b78 to ClassicPress. * WP-r56617: KSES: Add `writing-mode` to the list of safe CSS properties. Original PR from Gutenberg repository: * [WordPress/gutenberg#54581 https://core.trac.wordpress.org/ticket/54581 Gutenberg Plugin: Add hook to allow `writing-mode` as a safe CSS property] Reference: [https://developer.mozilla.org/en-US/docs/Web/CSS/writing-mode MDN Web Docs: writing-mode]. Follow-up to https://core.trac.wordpress.org/changeset/56605. WP:Props wildworks, mukesh27, poena, andrewserong. Fixes https://core.trac.wordpress.org/ticket/59387. --- Merges https://core.trac.wordpress.org/changeset/56617 / WordPress/wordpress-develop@cf2f441515 to ClassicPress. * WP-r57056: Coding Standards: Remove unnecessary ignore annotation in `wp_kses_hair_parse()`. It is perfectly possible to write a commented regex with layout for readability by using the `x` modifier. As per the manual: > x (`PCRE_EXTENDED`) > > If this modifier is set, whitespace data characters in the pattern are totally ignored except when escaped or inside a character class, and characters between an unescaped # outside a character class and the next newline character, inclusive, are also ignored. This is equivalent to Perl's /x modifier, and makes it possible to include commentary inside complicated patterns. > > Note, however, that this applies only to data characters. Whitespace characters may never appear within special character sequences in a pattern, for example within the sequence (?( which introduces a conditional subpattern. Reference: [https://www.php.net/manual/en/reference.pcre.pattern.modifiers.php PHP Manual: Pattern Modifiers]. This commit rewrites these two regexes to use the `x` modifier and gets rid of the unnecessary `phpcs:disable` comments. The tests in the `tests/phpunit/tests/db/dbDelta.php` file cover this change. Follow-up to https://core.trac.wordpress.org/changeset/42249. WP:Props jrf. See https://core.trac.wordpress.org/ticket/59650. --- Merges https://core.trac.wordpress.org/changeset/57056 / WordPress/wordpress-develop@13192d385f to ClassicPress. * WP-r57061: Coding Standards: Remove unnecessary ignore annotations in `dbDelta()`. It is perfectly possible to write a commented regex with layout for readability by using the `x` modifier. As per the manual: > x (`PCRE_EXTENDED`) > > If this modifier is set, whitespace data characters in the pattern are totally ignored except when escaped or inside a character class, and characters between an unescaped # outside a character class and the next newline character, inclusive, are also ignored. This is equivalent to Perl's /x modifier, and makes it possible to include commentary inside complicated patterns. > > Note, however, that this applies only to data characters. Whitespace characters may never appear within special character sequences in a pattern, for example within the sequence (?( which introduces a conditional subpattern. Reference: [https://www.php.net/manual/en/reference.pcre.pattern.modifiers.php PHP Manual: Pattern Modifiers]. This commit rewrites these two regexes to use the `x` modifier and gets rid of the unnecessary `phpcs:disable` comments. The tests in the `tests/phpunit/tests/db/dbDelta.php` file cover this change. Follow-up to https://core.trac.wordpress.org/changeset/42249. WP:Props jrf. See https://core.trac.wordpress.org/ticket/59650. --- Merges https://core.trac.wordpress.org/changeset/57061 / WordPress/wordpress-develop@0ac7b38407 to ClassicPress. * WP-r57228: KSES: Add `background-repeat` to the list of safe CSS properties. Follow-up to https://core.trac.wordpress.org/changeset/45242, https://core.trac.wordpress.org/changeset/46235. WP:Props andrewserong, ramonopoly, mukesh27. Fixes https://core.trac.wordpress.org/ticket/60132. --- Merges https://core.trac.wordpress.org/changeset/57228 / WordPress/wordpress-develop@0e28444795 to ClassicPress. * WP-r58170: Editor: add column and row spans to grid children. Adds support for setting spans using `grid-column` and `grid-row` properties on children of blocks with grid layout. WP:Props isabel_brison, andrewserong, peterwilsoncc, mukesh27. Fixes https://core.trac.wordpress.org/ticket/61111. Conflicts: - src/wp-includes/block-supports/layout.php - tests/phpunit/tests/block-supports/layout.php --- Merges https://core.trac.wordpress.org/changeset/58170 / WordPress/wordpress-develop@2b25b04f93 to ClassicPress. * WP-r58196: Docs: Add a `@since` note for the changes to `safecss_filter_attr()` in WP 6.6. Follow-up to https://core.trac.wordpress.org/changeset/58170. See https://core.trac.wordpress.org/ticket/61111. --- Merges https://core.trac.wordpress.org/changeset/58196 / WordPress/wordpress-develop@581f8d5eeb to ClassicPress. * WP-r58294: KSES: Allow leading trailing double hyphen in data attributes Expand allowable set of custom data attribute names to include those containing leading, trailing, and double `-` characters. Previously, WordPress was removing data attributes that are used in the Interactivity API. By allowing these additional custom data attributes, the related Interactivity API directives will preserve through `kses`. For example, the Interactivity API frequently relies on custom data attributes such as `data-wp-on--click="..."`. The change in https://core.trac.wordpress.org/changeset/43981 would strip these out of the processed HTML, however. Developed in WordPress/wordpress-develop#6598 Discussed in https://core.trac.wordpress.org/ticket/61052 WP:Props cbravobernal, dmsnell, gziolo, jonsurrell. Follow-up to https://core.trac.wordpress.org/changeset/43981. Fixes https://core.trac.wordpress.org/ticket/61052. Conflicts: - tests/phpunit/tests/kses.php --- Merges https://core.trac.wordpress.org/changeset/58294 / WordPress/wordpress-develop@89bec7acd8 to ClassicPress. * Fix merge conflict from 58294 * Fixes for backport test errors * WP-r58418: KSES: Preserve some additional invalid HTML comment syntaxes. When `wp_kses_split` processes a document it attempts to leave HTML comments alone. It makes minor adjustments, but leaves the comments in the document in its output. Unfortunately it only recognizes one kind of HTML comment and rejects many others. This patch makes a minor adjustment to the algorithm in `wp_kses_split` to recognize and preserve an additional kind of HTML comment: closing tags with an invalid tag name, e.g. `</%dolly>`. These invalid closing tags must be interpreted as comments by a browser. This bug fix aligns the implementation of `wp_kses_split()` more closely with its stated goal of leaving HTML comments as comments. It doesn't attempt to fully fix the mis-parsed comments, but it does propose a minor fix that hopefully won't break any existing code or projects. Developed in WordPress/wordpress-develop#6395 Discussed in https://core.trac.wordpress.org/ticket/61009 WP:Props ellatrix, dmsnell, joemcgill, jorbin, westonruter, zieladam. See https://core.trac.wordpress.org/ticket/61009. --- Merges https://core.trac.wordpress.org/changeset/58418 / WordPress/wordpress-develop@c756dfe8ca to ClassicPress. * WP-r58424: KSES: Fix tests and detection of HTML Bogus Comment spans. In https://core.trac.wordpress.org/changeset/58418 a test was added without the `test_` prefix in its function name, and because of that, it wasn't run in the test suite. The prefix has been added to ensure that it runs. In the original patch, due to a logical bug, a recursive loop to transform the inside contents of the bogus comments was never run more than once. This has been fixed. This patch also includes one more case where `kses` wasn't properly detecting the bogus comment state, and adds a test case to cover this. It limits itself to some but not all constructions of invalid markup declaration so that it doesn't conflict with existing behaviors around those and other kinds of invalid comments. WP:Props ellatrix, dmsnell. See https://core.trac.wordpress.org/ticket/61009. Follow-up to https://core.trac.wordpress.org/changeset/58418. --- Merges https://core.trac.wordpress.org/changeset/58424 / WordPress/wordpress-develop@b36ff6064a to ClassicPress. * WP-r58709: KSES: Add `opacity` to the list of safe CSS properties. Original PR from Gutenberg repository: * [WordPress/gutenberg#59891 https://core.trac.wordpress.org/ticket/59891 Update overlay step function in cover block] Reference: [https://developer.mozilla.org/en-US/docs/Web/CSS/opacity MDN Web Docs: opacity]. WP:Props sunil25393, wildworks, poena, Mamaduka, presstoke. Fixes https://core.trac.wordpress.org/ticket/61536. --- Merges https://core.trac.wordpress.org/changeset/58709 / WordPress/wordpress-develop@ad135d5f0a to ClassicPress. * WP-r59677: Formatting: Preserve `target="_blank"` in Biographical Info and Category Description. This changeset ensures the `target="_blank"` attribute is preserved when adding links in the Biographical Info and Category Description fields. Previously, this attribute was being stripped by the KSES sanitization process. Additionally, new unit tests have been added to verify the preservation of the `target="_blank"` attribute in these specific contexts. WP:Props lovewpmu, miqrogroove, bsutcliffe, sjefen6, nofearinc, nacin, harmr, blogitsolutions, stefahn, nirajgirixd, martinkrcho, spacedmonkey, sukhendu2002, audrasjb, gaellebesson, nuryko, guillaumeturpin, maximemeganck, ranafge, azaozz, joedolson, rinkalpagdar, mikinc860. Fixes https://core.trac.wordpress.org/ticket/12056. Conflicts: - tests/phpunit/tests/kses.php --- Merges https://core.trac.wordpress.org/changeset/59677 / WordPress/wordpress-develop@0f2334da81 to ClassicPress. * Fix merge conflict from 59677 * WP-r60405: Docs: Expand valid_unicode function documentation. The `valid_unicode()` function accepts a limited set of codepoints according to the XML specification. Document the allowed codepoints and link to relevant documentation. Developed in WordPress/wordpress-develop#9100. WP:Props jonsurrell, dmsnell. See https://core.trac.wordpress.org/ticket/6583, https://core.trac.wordpress.org/ticket/63166. --- Merges https://core.trac.wordpress.org/changeset/60405 / WordPress/wordpress-develop@d6355dc8d5 to ClassicPress. * WP-r60406: Coding Standards: Remove unnecessary conditional from `do_trackbacks()`. The check for a truthy `$to_ping` value is redundant, as a falsey value would cause the function to return early a few lines above. Follow-up to https://core.trac.wordpress.org/changeset/1794, https://core.trac.wordpress.org/changeset/2612. WP:Props justlevine. See https://core.trac.wordpress.org/ticket/63268. --- Merges https://core.trac.wordpress.org/changeset/60406 / WordPress/wordpress-develop@a99f57bc61 to ClassicPress. * WP-r60616: KSES: Prevent normalization from unescaping escaped numeric character references. Fixes an issue where `wp_kses_normalize_entities` would transform inputs like "&https://core.trac.wordpress.org/ticket/39;" into "&https://core.trac.wordpress.org/ticket/039;", changing the intended HTML text. This behavior has present since the initial version of KSES was introduced in https://core.trac.wordpress.org/changeset/649. https://core.trac.wordpress.org/changeset/2896 applied the normalization to post content for users without the "unfiltered_html" capability. Developed in WordPress/wordpress-develop#9099. WP:Props jonsurrell, dmsnell, sirlouen. Fixes https://core.trac.wordpress.org/ticket/63630. Conflicts: - src/wp-includes/kses.php - tests/phpunit/tests/kses.php --- Merges https://core.trac.wordpress.org/changeset/60616 / WordPress/wordpress-develop@b91b7576b8 to ClassicPress. * Fix merge conflicts from 60616 * WP-r60671: Formatting: Add 'white-space' as an allowed KSES CSS attribute. The 'white-space' attribute is safe, has wide browser support, and is useful. WP:Props sukhendu2002, mukesh27, whyisjake.. Fixes https://core.trac.wordpress.org/ticket/51707. --- Merges https://core.trac.wordpress.org/changeset/60671 / WordPress/wordpress-develop@171a547ae4 to ClassicPress. * WP-r60884: Editor: Allow popover attributes in editor content. Add attributes to KSES so that it's possible to create popover interactions natively in the editor. Adds `popovertarget`, `popovertargetaction` and `aria-haspopup` to `button`; `popover` to `div`, `ul`, and adds `dialog` with the attributes `open`, `closedby`, and `popover`. WP:Props harshdeepgill, jonsurrell, joedolson, sukhendu2002, flixos90, joedolson. Fixes https://core.trac.wordpress.org/ticket/61959. --- Merges https://core.trac.wordpress.org/changeset/60884 / WordPress/wordpress-develop@5810c47158 to ClassicPress. * WP-r60886: Editor: Add 6 missing HTML5 semantic tags (`data`, `meter`, `progress`, `search`, `time`, `wbr`) and their attributes to KSES. 1. `data` (attribute: `value`) 2. `meter` (attributes: `high`, `low`, `max`, `min`, `optimum`, `value`) 3. `progress` (attributes: `max`, `value`) 4. `search` 5. `time` (attribute: `datetime`) 6. `wbr` WP:Props ramiy, rollybueno, westonruter. Fixes https://core.trac.wordpress.org/ticket/63786. --- Merges https://core.trac.wordpress.org/changeset/60886 / WordPress/wordpress-develop@2fe26ceb7a to ClassicPress. * WP-r61017: KSES: add MathML tags. These tags are needed for the new Math block, which is included in WP 6.9. See WordPress/gutenberg#72182. See WordPress/wordpress-develop#10307. Fixes https://core.trac.wordpress.org/ticket/64115. --- Merges https://core.trac.wordpress.org/changeset/61017 / WordPress/wordpress-develop@b932ba04ef to ClassicPress. * WP-r61051: Editor: Allow `name` attribute on the `details` element in KSES. The `details` element supports the exclusive accordion behavior among multiple `details` elements by setting a common `name` attribute. The ability to set the `name` attribute in the Details block was added in of Gutenberg 20.2. However, when a user without `unfiltered_html` attempts to save the post, the `name` attribute gets erroneously stripped out. This prevents that. See [WordPress/gutenberg#56969 Details block: Exclusive accordions]. Follow-up to https://core.trac.wordpress.org/changeset/14406, https://core.trac.wordpress.org/changeset/59775. WP:Props soean. See https://core.trac.wordpress.org/ticket/12835, https://core.trac.wordpress.org/ticket/62887. Fixes https://core.trac.wordpress.org/ticket/64127. --- Merges https://core.trac.wordpress.org/changeset/61051 / WordPress/wordpress-develop@d0c86cdc8e to ClassicPress. * WP-r61436: Code Modernization: Formatting: Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to https://core.trac.wordpress.org/changeset/61435, https://core.trac.wordpress.org/changeset/61434, https://core.trac.wordpress.org/changeset/61403, https://core.trac.wordpress.org/changeset/61433, https://core.trac.wordpress.org/changeset/61432, https://core.trac.wordpress.org/changeset/61431, https://core.trac.wordpress.org/changeset/61430, https://core.trac.wordpress.org/changeset/61429, https://core.trac.wordpress.org/changeset/61424, https://core.trac.wordpress.org/changeset/61404, https://core.trac.wordpress.org/changeset/61403. WP:Props costdev, westonruter. See https://core.trac.wordpress.org/ticket/58874, https://core.trac.wordpress.org/ticket/63430. --- Merges https://core.trac.wordpress.org/changeset/61436 / WordPress/wordpress-develop@6d60f73c83 to ClassicPress. * WP-r61486: Customize: Allow arbitrary CSS in global styles custom CSS. Relax Global Styles custom CSS filters to allow arbitrary CSS. Escape HTML characters `<>&` in Global Styles data to prevent it from being mangled by post content filters. The data is JSON encoded and stored in `post_content`. Filters operating on `post_content` expect it to contain HTML. Some KSES filters would otherwise remove essential CSS features like the `<custom-ident>` CSS data type because they appear to be HTML tags. https://core.trac.wordpress.org/changeset/61418 changed STYLE tag generation to use the HTML API for improved safety. Developed in WordPress/wordpress-develop#10641. WP:Props jonsurrell, dmsnell, westonruter, ramonopoly, oandregal, jorgefilipecosta, sabernhardt, soyebsalar01. See https://core.trac.wordpress.org/ticket/64418. Conflicts: - src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php - tests/phpunit/tests/rest-api/rest-global-styles-controller.php --- Merges https://core.trac.wordpress.org/changeset/61486 / WordPress/wordpress-develop@101a21f4f4 to ClassicPress. * WP-r61565: Editor: screen size based block visibility support. Adds ability to hide blocks at different screen sizes to the block visibility support. WP:Props ramonopoly, isabel_brison, westonruter. Closes https://core.trac.wordpress.org/ticket/64414. Conflicts: - src/wp-includes/block-supports/block-visibility.php - tests/phpunit/tests/block-supports/block-visibility.php --- Merges https://core.trac.wordpress.org/changeset/61565 / WordPress/wordpress-develop@5885cb96a9 to ClassicPress. * WP-r61882: KSES: Optimize PCRE pattern detecting numeric character references. WP:Props dmsnell, xknown, johnbillion. --- Merges https://core.trac.wordpress.org/changeset/61882 / WordPress/wordpress-develop@695c31e4cb to ClassicPress. * WP-r62530: KSES: Allow SVG presentation attributes in safe_style_css. Add SVG presentation attributes to the list of CSS properties allowed by `safecss_filter_attr()`, so inline SVG markup can be styled via the `style` attribute. This ports Gutenberg PR https://core.trac.wordpress.org/ticket/79172 to Core. WP:Props afercia, westonruter, wildworks. Fixes https://core.trac.wordpress.org/ticket/65457. --- Merges https://core.trac.wordpress.org/changeset/62530 / WordPress/wordpress-develop@e904e28cdd to ClassicPress. * WP-r62531: KSES: Add command and commandfor to the list of allowed attributes for buttons. Developed in: WordPress/wordpress-develop#11483 WP:Props pratiknawkar94, joedolson, westonruter, afercia. Fixes https://core.trac.wordpress.org/ticket/64576. --- Merges https://core.trac.wordpress.org/changeset/62531 / WordPress/wordpress-develop@e3c26545b1 to ClassicPress. * Use available test assertion for 62531 * WP-r62550: Code Modernization: Use `array_any()` where appropriate. This commit replaces several `foreach` loops that iterate an array, return `true` as soon as an element matches a condition, and otherwise fall through to `false`. That is exactly what PHP 8.4's `array_any()` expresses in a single, more readable call. WordPress core includes a polyfill for `array_any()` on PHP < 8.4 as of WordPress 6.8, so the change works on every supported PHP version without raising the minimum requirement. Follow-up to https://core.trac.wordpress.org/changeset/59783. WP:Props Soean, mukesh27, SergeyBiryukov. See https://core.trac.wordpress.org/ticket/65519. Conflicts: - src/wp-includes/block-template-utils.php - src/wp-includes/class-wp-block-processor.php --- Merges https://core.trac.wordpress.org/changeset/62550 / WordPress/wordpress-develop@a1314bbebc to ClassicPress. * WP-r62699: Coding Standards: Use `in_array()` instead of `array_search()` for existence checks. Several places in core use `array_search()` purely to determine whether a value exists in an array, comparing the result against `false`. In these cases the returned key/position is never used, so `in_array()` expresses the intent more clearly and avoids computing a return value that is discarded. This commit replaces those existence-only `array_search()` calls with `in_array()`. The strict (`true`) comparison flag is preserved in every case, so there is no change in behavior. WP:Props Soean. See https://core.trac.wordpress.org/ticket/64897. --- Merges https://core.trac.wordpress.org/changeset/62699 / WordPress/wordpress-develop@eb881494d9 to ClassicPress. * WP-r62708: KSES: Add `tabindex` to the list of allowed global attributes. Add `tabindex` to the list of global attributes allowed by `_wp_add_global_attributes()`, so it survives KSES filtering on any element that supports global attributes. Developed in: WordPress/wordpress-develop#12493 WP:Props ramonopoly, wildworks. Fixes https://core.trac.wordpress.org/ticket/65619. --- Merges https://core.trac.wordpress.org/changeset/62708 / WordPress/wordpress-develop@d6f6780a5a to ClassicPress. * WP-r62718: Block Supports: Add background gradient support that can combine with background image Adds `background.gradient` as a new block support, enabling blocks to combine a background gradient with a background image via comma-separated `background-image` CSS values (e.g., `background-image: linear-gradient(...), url(...)`). Before, the only way to apply a gradient is through `color.gradient`, which renders as a `background` CSS shorthand and conflicts with background image properties. By introducing `background.gradient` (stored at `style.background.gradient`), gradients become part of the background style group, allowing the style engine to combine gradient and image values without conflict. WP:Props aaronrobertshaw, ramonopoly, wildworks. Fixes https://core.trac.wordpress.org/ticket/64974. Conflicts: - src/wp-includes/block-supports/background.php - src/wp-includes/block-supports/colors.php - src/wp-includes/class-wp-theme-json.php - src/wp-includes/style-engine/class-wp-style-engine.php - tests/phpunit/tests/block-supports/colors.php - tests/phpunit/tests/block-supports/wpRenderBackgroundSupport.php - tests/phpunit/tests/style-engine/styleEngine.php - tests/phpunit/tests/theme/wpThemeJson.php --- Merges https://core.trac.wordpress.org/changeset/62718 / WordPress/wordpress-develop@6b190c64b2 to ClassicPress. * WP-r62850: KSES: Allow the autofocus attribute on dialog elements. First step to allow the usage of the autofocus attribute for native dialog elements. More work will follow to add a context-aware mechanism to KSES and allow the attribute on dialog element children. WP:Props westonruter, joedolson, mukesh27, afercia. Fixes https://core.trac.wordpress.org/ticket/65491. --- Merges https://core.trac.wordpress.org/changeset/62850 / WordPress/wordpress-develop@05d3b3cec4 to ClassicPress. * Use available test assertion for 62850 * WP-r63180: KSES: Allow functional CSS values in inline styles. The presentation properties allowlisted in https://core.trac.wordpress.org/changeset/62530 were accepted in name only: any declaration whose value contained a function call was dropped in full, so for users without the `unfiltered_html` capability those properties remained unusable in their canonical form. URL references are routed through the existing protocol validation, so the security model is unchanged. Developed in: WordPress/wordpress-develop#12942 Follow-up to https://core.trac.wordpress.org/changeset/62530. WP:Props courane01, hasnainashfaq, irozum, khokansardar, mdridipu, tyxla. Fixes https://core.trac.wordpress.org/ticket/65832. --- Merges https://core.trac.wordpress.org/changeset/63180 / WordPress/wordpress-develop@996c6d6864 to ClassicPress. * WP-r63320: Docs: Remove a blank line between `@param` and `@return` in core docblocks. The [https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/ PHP inline documentation standards] place `@return` immediately after the last `@param` tag, with no blank line between them: {{{ /** * Summary. * * @SInCE x.x.x * * @PARAM string $var Description. * @return string Description. */ }}} This corrects 44 docblocks across 33 files in `src/wp-includes` that used a line break between the two tags. Developed in WordPress/wordpress-develop#13063. WP:Props mukesh27, dhruvang21. See https://core.trac.wordpress.org/ticket/65818, https://core.trac.wordpress.org/ticket/65860. Conflicts: - src/wp-includes/block-editor.php - src/wp-includes/block-supports/aria-label.php - src/wp-includes/block-supports/block-style-variations.php - src/wp-includes/block-supports/colors.php - src/wp-includes/block-supports/custom-classname.php - src/wp-includes/block-supports/settings.php - src/wp-includes/block-supports/utils.php - src/wp-includes/block-template-utils.php - src/wp-includes/block-template.php - src/wp-includes/blocks.php - src/wp-includes/class-wp-block-type.php - src/wp-includes/class-wp-textdomain-registry.php - src/wp-includes/class-wp-theme-json-data.php - src/wp-includes/class-wp-theme-json-schema.php - src/wp-includes/class-wp-token-map.php - src/wp-includes/deprecated.php - src/wp-includes/functions.php - src/wp-includes/global-styles-and-settings.php - src/wp-includes/html-api/class-wp-html-doctype-info.php - src/wp-includes/html-api/class-wp-html-processor.php - src/wp-includes/html-api/class-wp-html-tag-processor.php - src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php - src/wp-includes/rest-api/endpoints/class-wp-rest-widget-types-controller.php - src/wp-includes/theme.php - src/wp-includes/user.php --- Merges https://core.trac.wordpress.org/changeset/63320 / WordPress/wordpress-develop@728a605348 to ClassicPress. * WP-r63910: KSES: Allow CSS anchor position properties. Adds CSS anchoring properties to the `safecss_filter_attr()` allow list: * `anchor-name` * `anchor-scope` * `position-anchor` * `position-area` * `position-try` * `position-try-fallbacks` * `position-try-order` * `position-visibility` WP:Props deepakprajapati, wildworks, adrianduffell, dannyreaktiv, im3dabasia1, westonruter. Fixes https://core.trac.wordpress.org/ticket/64972. --- Merges https://core.trac.wordpress.org/changeset/63910 / WordPress/wordpress-develop@6b08132f3f to ClassicPress. * Delete shadow.php - not needed --------- Co-authored-by: Sergey Biryukov <sergeybiryukov@git.wordpress.org> Co-authored-by: Peter Wilson <peterwilsoncc@git.wordpress.org> Co-authored-by: Isabel Brison <isabel_brison@git.wordpress.org> Co-authored-by: Jb Audras <audrasjb@git.wordpress.org> Co-authored-by: Colin Stewart <costdev@git.wordpress.org> Co-authored-by: Dennis Snell <dmsnell@git.wordpress.org> Co-authored-by: Jon Surrell <jonsurrell@git.wordpress.org> Co-authored-by: Timothy Jacobs <timothyblynjacobs@git.wordpress.org> Co-authored-by: Joe Dolson <joedolson@git.wordpress.org> Co-authored-by: Weston Ruter <westonruter@git.wordpress.org> Co-authored-by: Ella Van Durpe <ellatrix@git.wordpress.org> Co-authored-by: John Blackbourn <johnbillion@git.wordpress.org> Co-authored-by: Aki Hamano <wildworks@git.wordpress.org> Co-authored-by: Andrea Fercia <afercia@git.wordpress.org> Co-authored-by: ramonopoly <ramonopoly@git.wordpress.org> CP:Props: mattyrob, xxsimoxx

Update overlay step function

1e5b09d

akasunil requested a review from ajitbohra as a code owner March 15, 2024 06:53

Update unit test

21342ac

skorasaurus added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label Apr 2, 2024

akasunil added 2 commits April 15, 2024 14:56

Merge branch 'trunk' of personal.github.com:sunil25393/gutenberg into…

effde34

… fix-issue-51625

Update cover block snapshots

c4688d3

akasunil requested review from artemiomorales and michalczaplinski as code owners April 15, 2024 12:28

akasunil added 4 commits April 15, 2024 18:40

Updated fixtures

83c804d

Updated native tests

b63d2f3

Merge branch 'trunk' of personal.github.com:sunil25393/gutenberg into…

b04806f

… fix-issue-51625

Add opacity to allowed inline style attributes list

c801135

akasunil requested a review from spacedmonkey as a code owner April 18, 2024 09:11

akasunil added 2 commits April 18, 2024 19:02

Update unit test

0244c85

Fix fixures of cover block

9d99de6

akasunil marked this pull request as draft April 19, 2024 06:23

updated native snapshots for core blocks

860cfc2

akasunil marked this pull request as ready for review April 19, 2024 09:55

akasunil mentioned this pull request Apr 19, 2024

Cover Block: Overlay is only possible in 10-steps instead of 1 - Disable Rounding #51625

Open

stokesman added the [Type] Enhancement A suggestion for improvement. label May 3, 2024

Synced and resolved conflicts

0d0eaad

Merge branch 'trunk' of personal.github.com:akasunil/gutenberg into f…

be01b98

…ix-issue-51625

akasunil added 4 commits June 27, 2024 19:30

Merge branch 'trunk' of personal.github.com:akasunil/gutenberg into f…

ed65ee8

…ix-issue-51625

Move compatibility files to 6.7

eca5616

Revert changes from of 6.5 compatibility files

2042d00

Merge branch 'trunk' of personal.github.com:akasunil/gutenberg into f…

bcd8574

…ix-issue-51625

akasunil mentioned this pull request Jun 29, 2024

Add opacity as an allowed attribute to safecss_filter_attr() WordPress/wordpress-develop#6943

Closed

akasunil added 2 commits June 29, 2024 11:19

Add backport changelog

878f559

Merge branch 'trunk' of personal.github.com:akasunil/gutenberg into f…

42d9487

…ix-issue-51625

Synced with trunk and resolved conflicts

e7c9e7a

youknowriad requested review from aaronrobertshaw, stokesman and t-hamano July 15, 2024 09:44

aaronrobertshaw reviewed Jul 16, 2024

View reviewed changes

gutenbergplugin requested a review from fabiankaegy as a code owner January 28, 2026 10:51

SainathPoojary mentioned this pull request Aug 26, 2026

Cover block: unlock ability to set specific percentage on overlay #82083

Closed

Conversation

akasunil commented Mar 15, 2024

What?

Why?

How?

Testing Instructions

Screenshots or screencast

Uh oh!

github-actions Bot commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akasunil commented Apr 23, 2024

Uh oh!

Mamaduka commented Apr 30, 2024

Uh oh!

akasunil commented May 1, 2024

Uh oh!

stokesman commented May 3, 2024

Uh oh!

akasunil commented May 4, 2024

Uh oh!

stokesman commented May 7, 2024

Uh oh!

akasunil commented May 10, 2024

Uh oh!

akasunil commented Jun 17, 2024

Uh oh!

carolinan commented Jun 27, 2024

Uh oh!

carolinan commented Jun 27, 2024

Uh oh!

akasunil commented Jun 29, 2024

Uh oh!

aaronrobertshaw left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Backwards Compatibilty

Alternative Approach

Uh oh!

ndiego commented Jul 16, 2024

Uh oh!

richtabor commented Jul 17, 2024

Uh oh!

akasunil commented Jul 21, 2024

Uh oh!

aaronrobertshaw commented Jul 21, 2024

Uh oh!

richtabor commented Jul 21, 2024

Uh oh!

ramonjd commented Jul 22, 2024

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

github-actions Bot commented Mar 15, 2024 •

edited

Loading

aaronrobertshaw left a comment •

edited

Loading