Add: Support for menu group to the Dropdown#59723
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
enejb
added
[Package] Components
|
Size Change: +520 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Contributor
|
Looks good to me. Will refer to Marin for the ✅! |
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Add: Support for menu group to the Dropdown * Remove the duplicate scss * Remove the DropdownContentWrapper in story Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * remove comment Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Remove the DropdownContentWrapper in story Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Update Changelog --------- Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> Co-authored-by: enejb <enej@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
What?
This PR adds nicer styling for the MenuGroup component when it is places inside the DropDown menu,
Why?
This make the default styling of the MenuGroup much nicer when it is places inside the DropDown component.
How?
This PR just adds additional styles for MenuGroup to the DropDown menu.
Testing Instructions
Start Storyboard
npm run storybook:devOpen the http://localhost:50240/?path=/story/components-dropdown--with-menu-items
Visit
http://localhost:50240/?path=/story/components-dropdownmenu--with-children notice that it still looks the same.
Screenshots or screencast