Make command palette string transatables#59133
Make command palette string transatables#59133t-hamano merged 4 commits intoWordPress:trunkfrom MarieComet:fix/command-palette-strings-i18n
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I See Your PR Looks Good. Thanks for PR |
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Great catch!
I believe these changes are correct, but it seems to be failing the lint check because it's indented with spaces instead of tabs. If you commit the suggestions below, it should be resolved.
At the same time, I also fixed the placeholder format (%1$s), which was originally incorrect.
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
t-hamano
added
[Type] Bug
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
|
Hi @t-hamano |
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! GitHub Actions is all ✅. Thanks for your great work!
* Make command palette string transatables * Apply suggestions from code review Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Fix %1$s in command palette comment translation * fix lint JS in use-edit-mode-command.js --------- Co-authored-by: MarieComet <chaton666@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: e14c1d9 |
* Make command palette string transatables * Apply suggestions from code review Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Fix %1$s in command palette comment translation * fix lint JS in use-edit-mode-command.js --------- Co-authored-by: MarieComet <chaton666@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
5 participants
See the related issue : #59132