Repository navigation
Components: Add sleep() before all Tab() to fix flaky tests - #59012
Conversation
tyxla
added
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in b84ba73. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7901704414
|
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Let's give this a try.
Is there an issue for resolving the root cause of the flakiness? We should probably include reverting "hacks" like these as a follow-up step there.
Good idea. I've opened #59071 to keep track of this. |
What?
This PR adds some additional
sleep()calls before allpress.Tab()calls to fix the flakiness.Why?
To reduce the test flakiness. Another
press.Tab()test failed right during merging #58968 to trunk so I think we should apply this everywhere and see how it goes.How?
We're adding some wait time (10ms which is the default of
sleep()) before tabbing.This doesn't really fix the root cause, but we're aiming to fix the flaky tests for now.
We also did this in #58629 and #58968.
Testing Instructions
Verify all tests pass.
Testing Instructions for Keyboard
None
Screenshots or screencast
None