Repository navigation
DataViews: Add loading/no results message in grid view - #59002
Merged
Merged
Conversation
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
glendaviesnz,
kevin940726,
oandregal and
youknowriad
February 14, 2024 10:06
|
Size Change: +82 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bac80fd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7899535635
|
oandregal
approved these changes
Feb 14, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 1e70298 |
youknowriad
added
the
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #58482
This PR adds a simple loading and no results message in DataViews grid view. For now is just a simple text, identical to
tableandlistviews.I had to update a bit the hooks used for patterns fetching, because in some cases the
isResolvingvalue was hardcoded tofalse.Testing Instructions
Screenshots or screencast