Conversation
…experimental phase
glendaviesnz
added
[Type] Bug
|
Size Change: +89 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 613f31d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7721117227
|
talldan
added
the
Backport to Gutenberg RC
talldan
approved these changes
Jan 31, 2024
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Works well, thanks for fixing this quickly!
I left one minor comment.
Comment on lines
+81
to
+86
| if ( | ||
| name === 'core/paragraph' || | ||
| name === 'core/heading' || | ||
| name === 'core/image' || | ||
| name === 'core/button' | ||
| ) { |
Contributor
There was a problem hiding this comment.
I'm not sure this if statement is needed as the one on the line after this already checks for the existence of the bindings attribute, which indicates the block has bindings.
Alternatively the two if statements can be combined to if we want to prevent the logic running on more block types that might be supported in the future:
if (
newAttributes.metadata?.bindings && (
name === 'core/paragraph' ||
name === 'core/heading' ||
name === 'core/image' ||
name === 'core/button'
)
) {The code will be a hot path for loading the editor, so making sure the cheapest statement is first seems like a good idea.
talldan
changed the title
gziolo
reviewed
Jan 31, 2024
| newAttributes.legacy = true; | ||
| } | ||
|
|
||
| // Convert pattern overrides added during experimental phase. |
Member
There was a problem hiding this comment.
This logic is only necessary in the Gutenberg plugin so it can be put behind the check:
gutenberg/tools/webpack/shared.js
Line 67 in 82e22bf
This way it won't get included in WordPress core.
cbravobernal
pushed a commit
that referenced
this pull request
Jan 31, 2024
…ntal phase (#58483) * Update the bindings attribs of blocks added during pattern overrides experimental phase * Update all the binding attributes * Minor optimization / code quality change --------- Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
Contributor
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 63c3c4e |
cbravobernal
removed
the
Backport to Gutenberg RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Maps the old source attribute name of
name: 'pattern_attributes'tocore/pattern-overridesWhy?
In #58434 the binding attribute was updated which means that any pattern overrides add before this change no longer work, and it isn't possible to manually update them as the
Allow pattern overridestoggle does not appear.How?
Uses the
convertLegacyBlockNameAndAttributesmethod to map to the new naming.Testing Instructions
Screenshots or screencast
Before:
attribs-before.mp4
After:
attribs-after.mp4