Update types for debounce utility function parameter#58330
Update types for debounce utility function parameter#58330sandymcfadden wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sandymcfadden! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Hi @sandymcfadden, thanks for the PR. I'd like to better understand the motivation for this change. Will you some examples of where this type is causing difficulties? My first impression is that I'd be reluctant to make a change like this. Introducing |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
3 participants
What?
Update the types for the debounce utility function from unknown to any.
Why?
We were getting type errors using the debounce function in an external Typescript project.
This seems to match the lodash debounce types better here and resolves the type errors we were seeing.
I don't believe this causes any errors or should cause any problems for other uses of this function, but if this is not the right approach or an appropriate fix please feel free to close.
Testing Instructions
Ensure tests run appropriately and no type errors are introduced