Repository navigation
Components: replace TabPanel with Tabs in the Font Library Modal - #57181
Merged
Merged
Conversation
27 of 36 tasks
|
Size Change: -10 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
chad1008
force-pushed
the
tabs-font-library-modal
branch
from
December 18, 2023 20:51
086a3d4 to
e0a6006
Compare
chad1008
marked this pull request as ready for review
December 19, 2023 22:40
ciampo
force-pushed
the
tabs-font-library-modal
branch
from
December 22, 2023 09:37
e0a6006 to
4da77d1
Compare
ciampo
reviewed
Dec 22, 2023
ciampo
left a comment
ciampo
left a comment
Contributor
There was a problem hiding this comment.
I rebased this PR to include the latest changes (including updates to node/npm version).
Just for fun, modify the order of the
DEFAULT_TABSarray
I had lots of fun, thank you for recommending this activity!
ciampo
changed the title
TabPanel with Tabs in the Font Library ModalTabPanel with Tabs in the Font Library Modal
chad1008
force-pushed
the
tabs-font-library-modal
branch
from
January 2, 2024 15:35
4da77d1 to
8c2a183
Compare
chad1008
force-pushed
the
tabs-font-library-modal
branch
from
January 2, 2024 18:17
b3d65a1 to
1def6f1
Compare
|
Flaky tests detected in 1def6f1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7389121467
|
Contributor
Author
|
rebased, CI checks are passing! |
ciampo
approved these changes
Jan 3, 2024
ciampo
left a comment
ciampo
left a comment
Contributor
There was a problem hiding this comment.
🚀
Good to merge after all feedback gets addressed
Contributor
Author
|
Thanks @ciampo, waiting on CI checks now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces the legacy TabPanel component with the new Tabs component.
Why?
Part of the work outlined in #52997
How?
TabPanelis replaced byTabsand its sub-components. I've also tried to clean up the use ofnamevsidfor tab identification.TabPanelused anameproperty, butTabsdeals exclusively withids. Eliminatingnamefrom the code will hopefully make it easier to parse. This specifcially doesn't impact thenameproperty on font collections being passed in to the library, as that nomenclature still felt like it made sense.Testing Instructions
trunk, confirm that each tab visually looks the same, that it behaves the same, and the it's displaying the correct contentDEFAULT_TABSarray inpackages/edit-site/src/components/global-styles/font-library-modal/index.jsso thatinstalled-fontsis no longer listed first. Reload the site editor and confirm that Library is still the initially selected tab even if it the first one in the listTesting Instructions for Keyboard
tabpanelcontents.