Skip to content

Implement Tabs in site-editor settings #56959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chad1008 merged 10 commits into from
Feb 2, 2024
Merged

Implement Tabs in site-editor settings #56959

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b1c0a29
take that, slot/fill!
chad1008 Dec 11, 2023
7b21c85
panel margin style fix
chad1008 Dec 11, 2023
e3bee18
style updates
chad1008 Dec 11, 2023
7b04524
e2e test updates
chad1008 Dec 11, 2023
dd7fd69
ensure canvas is in edit mode
chad1008 Dec 13, 2023
225aba3
fix tabpanel ids
chad1008 Dec 14, 2023
21587d5
update new playwright tests
chad1008 Jan 2, 2024
883f800
disable `selectOnMove`
chad1008 Jan 3, 2024
b5cd94e
address tab flow race condition
chad1008 Feb 1, 2024
65a8221
implement feedback
chad1008 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tabpanel ids
  • Loading branch information
@chad1008
chad1008 committed Feb 2, 2024
commit 225aba3a56a27e93321f33fd9b1b92b5f7cd6324
8 changes: 5 additions & 3 deletions packages/edit-site/src/components/sidebar-edit-mode/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,14 @@ const FillContents = ( {
className="edit-site-sidebar__panel"
>
<Tabs.Context.Provider value={ tabsContextValue }>
<Tabs.TabPanel id={ SIDEBAR_BLOCK } focusable={ false }>
<Tabs.TabPanel
tabId={ SIDEBAR_TEMPLATE }
focusable={ false }
>
{ isEditingPage ? <PagePanels /> : <TemplatePanel /> }
<PluginTemplateSettingPanel.Slot />
</Tabs.TabPanel>

<Tabs.TabPanel id={ SIDEBAR_TEMPLATE } focusable={ false }>
<Tabs.TabPanel tabId={ SIDEBAR_BLOCK } focusable={ false }>
<InspectorSlot bubblesVirtually />
</Tabs.TabPanel>
</Tabs.Context.Provider>
Expand Down