Skip to content

Fix/remove empty space from inserter#56926

Closed
n2erjo00 wants to merge 2 commits intoWordPress:trunkfrom
n2erjo00:fix/remove-empty-space-from-inserter
Closed

Fix/remove empty space from inserter#56926
n2erjo00 wants to merge 2 commits intoWordPress:trunkfrom
n2erjo00:fix/remove-empty-space-from-inserter

Conversation

@n2erjo00
Copy link
Copy Markdown
Contributor

@n2erjo00 n2erjo00 commented Dec 10, 2023

What?

This PR is removing unnecessary empty space(s) in the Inserter panel.

Why?

Closes #56802

In the inserter panel the goal is to remove space between content area and search results

How?

The InserterPanel component takes a title property. After checking Gutenberg codebase revealed that property is either plain string or VisuallyHidden component. Added logic now checks whether title property is specifically VisuallyHidden component and use proper classes after that

Testing Instructions

  1. Open a post or page.
  2. Open Inserter panel
  3. Observe the labels before block listing
  4. Search for "Social" and observe there is no empty space before the list(s).
  5. Search for "Social with" this returns pattern list and again observe no empty space before the list and hover effect still works on the pattern list items

This one hard to describe. Please also check the linked issue there are some really good screenshots (one picture versus million words)

Testing Instructions for Keyboard

Screenshots or screencast

@n2erjo00 n2erjo00 requested a review from ellatrix as a code owner December 10, 2023 09:30
@cbravobernal cbravobernal added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Dec 10, 2023
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Feb 20, 2024
@richtabor
Copy link
Copy Markdown
Member

richtabor commented Apr 24, 2024

Hey @n2erjo00, stumbled upon this while exploring #61051. If that idea goes through, we won't need to check for visibility as those labels would be persistent throughout.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 24, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: n2erjo00 <n2erjo00@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@richtabor
Copy link
Copy Markdown
Member

richtabor commented Apr 24, 2024

I think we should close this; but I could use a hand with the Inserter optimizations visualized as a part of #61051.

@n2erjo00
Copy link
Copy Markdown
Contributor Author

n2erjo00 commented Apr 25, 2024

@richtabor Makes sense, let's close this one.

I can checkout the linked issue later this week. Is there anything specific you'd need help with?

@richtabor
Copy link
Copy Markdown
Member

richtabor commented Apr 25, 2024

I think the search results for patterns and blocks from the block directory could use cleaning up. The results in general are difficult to parse as-is.

@richtabor richtabor closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees

No one assigned

Labels

[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extraneous space above inserter search results

4 participants

@n2erjo00 @richtabor @Mamaduka @cbravobernal