DimensionControl: Add __next40pxDefaultSize prop#56805
Merged
Conversation
brookewp
added
[Type] Enhancement
|
Flaky tests detected in 33de2a9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7122906844
|
brookewp
force-pushed
the
add/40px-size-dimensioncontrol
branch
from
6190dce to
33de2a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #46741
What?
Add a new opt-in prop
__next40pxDefaultSizeto DimensionControl, following the plan outlined in above mentioned PR.Why?
For more consistency in styling.
How?
A new, temporary
__next40pxDefaultSizeprop. When the prop is set totrue, the inputs will have a height of 40px.Testing Instructions
In Storybook:
npm run storybook:dev__next40pxDefaultSizetotruefor DimensionControlIn the editor
Smoke test the component in the editor; DimensionControl shouldn't have any visible changes for now.