Lightbox: Fix close button position.#56125
Merged
Conversation
torounit
requested review from
artemiomorales and
michalczaplinski
as code owners
|
Flaky tests detected in 4325568. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6867731391
|
Member
Author
|
gutenberg/packages/block-library/src/image/style.scss Lines 375 to 392 in a1ccf42 The 50vw here should also be 50%. |
|
Size Change: -582 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Nov 15, 2023
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR! The approach seems to make sense to me too, but I'll leave a comment regarding one edge case.
michalczaplinski
approved these changes
Nov 15, 2023
Contributor
michalczaplinski
left a comment
michalczaplinski
left a comment
There was a problem hiding this comment.
Thanks for the PR! This approach seems sound to me! 👍
t-hamano
approved these changes
Nov 15, 2023
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM!
- ✅ When the document has the scrollbar
- ✅ When the document has the scrollbar and the body element has a fixed width
- ✅ When the document has no scrollbar
- ✅ When the document has no scrollbar and the body element has a fixed width
56da4c8fa14853253a1fc7ae0cf25ea0.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Changed the position of close button to be calculated from the inside of the scroll bar.
Why?
Fix #56052.
This problem is more noticeable in Chrome on Windows because of the wider scrollbars, but the same problem occurs when the scrollbars are displayed on a Mac.
How?
Change width of
.wp-lightbox-overlayto100%.Because
.wp-lightbox-overlayis a child element ofbody, 100% is the size of 100vw minus the width of the scrollbar.Within
keyframes100%is not computed. Instead100vw - $scrollbar-widthis used.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast