E2E Utils: Return block locator from createBlock()#55851
Closed
WunderBart wants to merge 1 commit intotrunkfrom
Closed
E2E Utils: Return block locator from createBlock()#55851WunderBart wants to merge 1 commit intotrunkfrom
WunderBart wants to merge 1 commit intotrunkfrom
Conversation
Mamaduka
reviewed
Nov 6, 2023
| return block; | ||
| }, blockRepresentation ); | ||
|
|
||
| return this.canvas.locator( `#block-${ clientId }` ); |
Member
There was a problem hiding this comment.
I haven't tested this, but one issue I can see is that if you reload the page after block insertion and try to use this locator in assertion, it will fail.
Member
Author
There was a problem hiding this comment.
Nice catch! I assumed the ID is persistent, so GTK it's not. 😄 At this point, I can't see any other persistent value of a newly inserted block that we could reference, so this isn't going to work. Closing!
Member
Author
|
See #55851 (comment) |
Member
|
Thanks for taking the time and exploring this idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast