Update/post term add toggle for no terms message#55680
Open
n2erjo00 wants to merge 3 commits intoWordPress:trunkfrom
Open
Update/post term add toggle for no terms message#55680n2erjo00 wants to merge 3 commits intoWordPress:trunkfrom
n2erjo00 wants to merge 3 commits intoWordPress:trunkfrom
Conversation
carolinan
added
[Type] Enhancement
carolinan
requested changes
Oct 30, 2023
Contributor
carolinan
left a comment
carolinan
left a comment
There was a problem hiding this comment.
The text in the new option is not suitable for all taxonomies, since it mentions "tags".
English is not my first language, but there are some grammatical errors.
Contributor
Author
|
@carolinan I am famously bad at coming up with labels and even worse at coming up with help texts 😅 (Not native English speaker either) Can we brainstorm suitable texts or altervative solution If the main problem is word "tags" maybe we could abstract it somehow. For example replace "No tags" with "No results" PS I totally forgot to use ChatGPT to check my grammar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55527
What?
This PR adds new block property to "Tags" block.
This property allows editors to control whether they want to show/hide "No tags" message from public side.
Why?
There was no control previously for this and editor would show this "No tags" message on the editor and nothing on public side.
How?
Added new block property for "Tags" block, created ToggleControl to allow editor to change state of that property and used that property on PHP render function.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast