Closed
Conversation
gziolo
added
[Type] Code Quality
Member
|
This package was fully converted in #64784. Apologies, I wasn't aware of this PR. I don't think there's anything that's left to be done. |
Member
|
@margolisj, is this PR still relevant? It’s been over year and there were several changes applied to the media utils package so it would be great to confirm and eventually bring the branch up to date. I think @swissspidy worked on improving TypeScript for the package recently. |
Contributor
Author
|
@gziolo No worries at all. @swissspidy Thanks for your work. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Converting Media Utils to TS
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast