Toolbar/ToolbarDropdownMenu Typescript Conversion#54321
Merged
ciampo merged 5 commits intoWordPress:trunkfrom Sep 11, 2023
Merged
Toolbar/ToolbarDropdownMenu Typescript Conversion#54321ciampo merged 5 commits intoWordPress:trunkfrom
ciampo merged 5 commits intoWordPress:trunkfrom
Conversation
Contributor
Author
ciampo
added
[Type] Code Quality
ciampo
reviewed
Sep 9, 2023
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀
Only needs a CHANGELOG entry (under the Internal subcategory)
Contributor
Author
Done! |
ciampo
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Upgrades test file for Toolbar/ToolbarDropdownMenu to typescript.
Why?
Typescript is the only sane was to maintain a JS codebase this large.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast