Adds removal notice to view.js.mustache#54105
Merged
mburridge merged 2 commits intoWordPress:trunkfrom Sep 1, 2023
Merged
Conversation
mburridge
added
[Tool] Create Block
gziolo
approved these changes
Sep 1, 2023
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Great addition, thank you for clarifying that since we don't want sites to load JS files that only log to the console 😄
gziolo
approved these changes
Sep 1, 2023
bph
added
[Type] Code Quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a line to
view.js.mustachein thecreate-blockpackage stating that it's safe to remove the file if no JavaScript is running in the front end.Why?
Because the file is not needed if no JavaScript is going to run in the front end.