Conversation
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
gziolo
added
the
[Type] Breaking Change
Member
|
I still need to test it locally but all the changes look good. There is a merging conflict in the changelog file that needs to be resolved. |
gziolo
approved these changes
Sep 1, 2023
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I can confirm that npm run lint:js continues to work locally.
Member
Author
|
Thanks @gziolo 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #52512
Update
@typescript-eslint/parser,@typescript-eslint/eslint-pluginandeslint-plugin-jestdependencies in@wordpress/eslint-pluginpackage.Why?
Unblocks projects that depend on latest version of
typescript-eslintand@wordpress/eslint-plugin.How?
@typescript-eslint/parserand@typescript-eslint/eslint-plugin.@typescript-eslint/no-duplicate-importrule (see https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-duplicate-imports.md) withimport/no-duplicates.eslint-plugin-jestto latest version.eslint-plugin-jestadded v6 oftypescript-eslintto their peerDependencies in 27.2.3.Testing Instructions
Run
npm run lint:js