Adds explanatory text to view.js template#53870
Merged
mburridge merged 4 commits intoWordPress:trunkfrom Aug 23, 2023
Merged
Conversation
mburridge
added
[Tool] Create Block
ryanwelcher
requested changes
Aug 22, 2023
Contributor
ryanwelcher
left a comment
ryanwelcher
left a comment
There was a problem hiding this comment.
LGTM! Just thinking we could simplify the text a little. I've left suggestions but feel free to make your own changes.
Accepting Ryan's suggestion Co-authored-by: Ryan Welcher <me@ryanwelcher.com>
Accepting Ryan's suggestion Co-authored-by: Ryan Welcher <me@ryanwelcher.com>
ryanwelcher
requested changes
Aug 22, 2023
Contributor
ryanwelcher
left a comment
ryanwelcher
left a comment
There was a problem hiding this comment.
I looks like an extra line was left in. Let's remove that and we're good to go!
Contributor
|
Looks like there is a failing test that needs to be addressed as well - https://github.com/WordPress/gutenberg/actions/runs/5940139652/job/16108070444?pr=53870 |
ryanwelcher
reviewed
Aug 22, 2023
juanmaguitar
approved these changes
Aug 23, 2023
ryanwelcher
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds some explanatory text to the
view.jstemplate in thecreate-blockpackage.Why?
This file, namely
view.js, was recently added to projects created with@wordpress/create-block, I believe due to the implementation of the Interactivity API (correct me if I'm wrong). For many people it's not clear what this file is for so some explanatory text has been added as a comment in the template file to clarify its purpose and usage.