Size Change: +870 B (0%)

Total Size: 1.51 MB

_{compressed-size-action}

Flaky tests detected in d168096.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5862306973
📝 Reported issues:

• [Flaky Test] allows rotating using the crop tools #36904 in /test/e2e/specs/editor/blocks/image.spec.js

Seems fine, but should the radius be changed like that? To me this counts as a modal and can keep its modal radius. Not the strongest opinion in the world, just curiuos as to the intent.

Seems fine, but should the radius be changed like that?

If not, then we should adjust the width so that it's fullwidth on mobile - like other modals are, but that looks off as the height changes based on the result count. As-is, the radius is 0 on the bottom.

Here's what the modal would look like, treated exactly like the modal component:

Should we add some margin on mobile, and keep the radius, so it isn't styled as a "bottom card" like that?

CC: @jameskoster I think you polished these recently.

Should we add some margin on mobile, and keep the radius, so it isn't styled as a "bottom card" like that?

You mean for the modal component? Perhaps.

I meant an override just for the command palette. But I guess the larger question is how that should behave on mobile altogether, so a big old "depends" on that one.

For reference, this is what modals look like currently:

Compared to the command palette (which grows based on command results):

An alternative would be to apply a min height on mobile to the command palette. Brings it more in line with modal, if that's what we want (should probably have a close button too then on mobile).

I could go quite a few ways on this one, including just picking one and revisiting as we learn more about this, so I'm happy to defer. I think the only change I'd feel slightly more about is to retaining the 4px radius :)

I think the only change I'd feel slightly more about is to retaining the 4px radius

Just realized I used the wrong unit — I'll fix :)

@jasmussen I updated the description with before/after recordings of the change.