Repository navigation
Add support for registering commands without icons - #53647
Conversation
|
Size Change: +130 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
jasmussen
left a comment
There was a problem hiding this comment.
Works well for me visually.
|
@Mamaduka do you know what this failure is? |
|
@richtabor yes, you should run |
Thanks, noted! |
|
Flaky tests detected in a28b625. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5870052669
|
|
@Mamaduka pinged ya for another quick double-check. Thanks! |
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks for the follow. This tests good for me 👍
What?
Closes #53193 by removing the requirement for commands to register icons. If the icon does not support the command, it probably shouldn't be required as part of the registration.
Testing Instructions
cogicons.Screenshots or screencast