Global styles revisions: reduce visibility check from 2 to 1 revision#53281
Merged
Global styles revisions: reduce visibility check from 2 to 1 revision#53281
Conversation
…e are more than 0 revisions since there is the default with which we can compare the single revision
ramonjd
added
[Type] Enhancement
|
Size Change: -3 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7b34eba. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5746576704
|
ntsekouras
approved these changes
Aug 3, 2023
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Looks good, thank you!
andrewserong
approved these changes
Aug 3, 2023
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for the follow-up, this is working nicely for me, too! ✨
Member
Author
|
Thanks for the speedy reviews! 🚀 |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Reduces the revisions count condition with which we determine whether to open the styles revisions panel from
1to2.Why?
Now that #52965 has merged, we can show the revisions panel when there are more than
0revisions since there is the default with which we can compare the single revision.Previously, the panel was only available after 2 styles revisions were saved in the database.
This makes things consistent with the command center as well, which will allow opening the styles revisions panel after 1 revision.
Testing Instructions
Start off with no style revisions. You shouldn't be able to open the styles revision panel from the site editor sidebar or the global styles panel.
Now add a single revision, e.g., change the background color of the site and save.
The revisions panel should now be accessible from the site editor sidebar or the global styles panel.