Repository navigation
List: merge consecutive lists - #52995
Merged
Merged
Conversation
ellatrix
added
the
[Feature] Writing Flow
|
Size Change: +73 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6ce4045. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5673416662
|
jorgefilipecosta
approved these changes
Sep 12, 2023
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
Member
There was a problem hiding this comment.
The change looks good to me 👍
I tried to find some hedge cases but did not find anything critically wrong. The most unexpected thing is if I have an empty group followed by a paragraph followed by another empty group. If I delete the paragraph using backspace I end up removing one of the groups and I get a single group with a paragraph inside. If I press backspace again the paragraph is removed and I get a single empty group. I think it is ok.
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #46039. When merging a paragraph that sits in between two lists of the same type, these two lists end up being side by side looking as one list, but are actually two separate lists.
Why?
It's confusing that the lists don't merge, and it's not easy to know that they don't.
How?
Checking the next block and merge nested items if the type and attributes match.
Testing Instructions
See #46039 (comment).
Testing Instructions for Keyboard
Screenshots or screencast