Global font sizes: Ensure sizes are unique#52483
Merged
Conversation
walbo
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 5b289af. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5511579157
|
Contributor
Is this legit or is the theme doing it wrong (just wondering)? |
youknowriad
requested review from
aaronrobertshaw,
andrewserong and
matiasbenedetto
Member
Author
I belive this is legit. Same happends in TT3 because it registers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Make sure font sizes in global styles are unique.
Why?
#51488 added font sizes from all origins in the global editor, but if a theme registeres a font size with the same slug as one of the default sizes an error is thrown.
In the Select control they are also listed as duplicates.
How?
Filter the font sizes and make sure all of them have a unique slug.
Testing Instructions
Add some font sizes to your theme.json that already exists in Gutenberg (or use the TT3 theme). Ex:
Open the global styles editor and change the text font size of your site. The console should not show any errors.