Repository navigation
Conversation
added 2 commits
June 19, 2023 17:19
… to use gutenberg_get_global_styles with resolve-variables context
…tor settings endpoint with the updated gutenberg_get_global_styles with the resolve-variables context
geriux
added
[Status] In Progress
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
Member
|
Since the React native implementation has been removed in #78747, I don't believe this pull request will be needed anymore. But feel free to reopen or submit a new pull request if there's still work to be done here. As noted in #54215 (comment), the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In progress
What?
With the newly added features in #50484 we can now pass the global styles data directly without manually parsing its values.
Why?
To avoid adding extra load to the mobile editor by parsing the theme json configuration manually.
How?
First, it adds a deprecation function to keep the existing behavior as we will have to keep the old support for a while until this change is shipped in a Gutenberg plugin version and probably up until a few months after WordPress 6.3 is released (mid August 2023). Since the changes in #50484 will ship in that version.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast