Fix site editor rendering of Categories block #51329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Categories block would not render properly within the site editor. Specifically: - Prefix and Suffix options were not shown when the block was selected. - Separator was not available in the advanced panel. - Alignment toolbar was not available in the toolbar.
mikachan
approved these changes
Jun 8, 2023
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
This is working well for me - it makes sense to move this logic into the main return statement with all the other conditional content.
Here is what I see in the Site Editor:
| Before | After |
|---|---|
 |
 |
I think we can bring this in! 🚢
Contributor
Author
|
Hello @mikachan @mirka and @apeatling I don't have merge authorization, so what can we do to bring this PR in? |
Member
I can merge this for you. Thank you for working on it! 🙇 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
The Categories block would not render properly within the site editor. Specifically: - Prefix and Suffix options were not shown when the block was selected. - Separator was not available in the advanced panel. - Alignment toolbar was not available in the toolbar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The Categories block would not render properly within the site editor. Specifically:
Why?
#48940 reported the issue of missing the alignment toolbar. As I was investigating that, I found out a few more things were missing.
How?
The component was returning early in case no
postIdwas found. Since nopostIdis present in the site editor, the early return was triggered. This PR makes sure that even in case we are in the site editor, we still output all the inspector controls, toolbars and prefix/suffix.Testing Instructions