Updated getEntityRecord doc by using selector instead of dispatch#51298
Merged
t-hamano merged 1 commit intoWordPress:trunkfrom Jun 11, 2023
Merged
Conversation
paulopmt1
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar,
ndiego and
ryanwelcher
as code owners
youknowriad
approved these changes
Jun 7, 2023
Contributor
|
Thanks for the fix. |
t-hamano
approved these changes
Jun 11, 2023
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM 👍 I have run the updated code in the browser console and confirmed that it works correctly.
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Update docs by using the selector instead dispatch while getting POST information from the store
Why?
Ensuring the docs reflect our selector's behavior
Testing Instructions
Ensure the following docs https://developer.wordpress.org/block-editor/explanations/architecture/entities/ uses
wp.data.select( 'core' ).getEntityRecord( 'postType', 'post', 1 );instead ofwp.data.dispatch( 'core' ).getEntityRecord( 'postType', 'post', 1 );Testing Instructions for Keyboard