Skip to content

Update the Modal Heading and Label text color value #50916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update the Modal Heading and Label text color value #50916

wants to merge 3 commits into from

Conversation

@falgunihdesai
Copy link
Contributor

@falgunihdesai falgunihdesai commented May 24, 2023 •
edited by stokesman
Loading

Update the Modal Heading and Label text color value so that it matches with the text color used for other areas of the editor. Previously it was using color from wp-admin common.css. Fixes #50448

What?

Why?

How?

Testing Instructions

  1. Open the WordPress page editor.2.
  2. Open the Preferences modal and check the colour value using inspect element.

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2023-05-24 at 2 56 21 PM Screenshot 2023-05-24 at 2 55 49 PM

@falgunihdesai
Update the Modal Heading and Label text color value.
14a1f72 
Update the Modal Heading and Label text color value so that it matches with the text color used for other areas of the editor.
Previously it was using color from wp-admin common.css. Fixes WordPress#5044
@falgunihdesai falgunihdesai requested a review from ajitbohra as a code owner May 24, 2023 16:11
@mtias mtias added the Needs Design Feedback Needs general design feedback. label Jun 2, 2023
jorgefilipecosta
jorgefilipecosta reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing regressions and this seems to work. Thank you for this PR @falgunihdesai.

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Sep 13, 2023

I'm going to cc: @richtabor to double-check if this is the expected result from the UX point of view.

@richtabor richtabor self-requested a review September 13, 2023 21:38
richtabor
richtabor approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mamaduka
Copy link
Member

Mamaduka commented Jul 29, 2025

I think we can merge this PR after rebasing and resolving merge conflicts.

@github-actions
Copy link

github-actions bot commented Jul 29, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: falgunihdesai <falgunihdesai@git.wordpress.org>
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ghorivipul97 <ghorivipul97@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 21, 2025
@kushagra-goyal-14 kushagra-goyal-14 mentioned this pull request Aug 22, 2025
Merged
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Aug 23, 2025
@juanfra
Copy link
Member

juanfra commented Sep 4, 2025

Thank you for working on this. Closing as fixed in #71311

@juanfra juanfra closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta left review comments

@richtabor richtabor richtabor approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

Needs Design Feedback Needs general design feedback. [Package] Components /packages/components [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modal headings and labels missing editor text color

7 participants

@falgunihdesai @jorgefilipecosta @Mamaduka @juanfra @richtabor @mtias @t-hamano