Updated unstyledButton hover selector to change fill of svg and path element#50819
Merged
mikachan merged 8 commits intoWordPress:trunkfrom Jun 9, 2023
Merged
Conversation
mikachan
reviewed
May 31, 2023
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
This is working well for me ✨ I've made one suggestion, let me know what you think!
mikachan
added
the
[Feature] Inserter
…-svg-on-hover-fill
mikachan
approved these changes
Jun 7, 2023
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
This is working great for me. I can see the icon color now matches the text color when the button state changes:
Thank you for working on this!
Member
|
It looks like you may need to run |
Contributor
Author
|
@mikachan Updated snapshot. Let's see what happens |
Member
|
Looks like that fixed the failing test! I've just pushed an update to the changelog too, but I'm not sure it's entirely necessary for this change. I think this is ready to bring in 👍 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…element (WordPress#50819) * Updated unstyledButton hover selector to change fill of svg and path elements * Changed placement svg selector and used css constant currentColor * Deleted :focus selector since it overrides browser default :focus-visible * Updated test snapshots * Update changelog * Fix PR URL in changelog * Fix indentation in CHANGELOG.md --------- Co-authored-by: Sarah Norris <sarah@sekai.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In the sidebar we have list of links to patterns and media files. Inside the button there is text (name of the pattern/name of the file) and svg icon (chevron pointing to right). When hovering over the button fill of svg does not change.
Changed how
:focusstate is handled to be more consistent with another view.Why?
Issue(s) were originally mentioned #50758 and in #50757
The goal is to make UX more consistent
How?
Extended button
:hoverto change fill ofsvgelements inside the buttonTesting Instructions for #50758
Testing Instructions for #50757
Testing Instructions for Keyboard
Screenshots or screencast