Cleaned up Port Validation and Removed Unnecessary Default Ports#50300
Merged
noahtallen merged 2 commits intoWordPress:trunkfrom May 4, 2023
ObliviousHarmony:fix/port-validation-and-parsing
Merged
Cleaned up Port Validation and Removed Unnecessary Default Ports#50300noahtallen merged 2 commits intoWordPress:trunkfrom ObliviousHarmony:fix/port-validation-and-parsing
noahtallen merged 2 commits intoWordPress:trunkfrom
ObliviousHarmony:fix/port-validation-and-parsing
Conversation
23 tasks
Contributor
|
Thank you for including my fix so fast! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This pull request changes the addition of ports to certain
wp-config.phpvalues to avoid adding default ports. I also made a small change to remove unnecessary parsing fromcheckPort.Why?
#49883 introduced a bug when using HTTP and HTTPS default ports. It adds them to the hostname even though they are not used and will cause issues.
How?
When we are attempting to add or replace the default HTTP port (
80) or the default HTTPS port (443), the port addition/replacement will not be performed.Testing Instructions
80.