Skip to content

Make eslint-plugin validate dependencies in useSelect and useSuspenseSelect hooks #49900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Make eslint-plugin validate dependencies in useSelect and useSuspenseSelect hooks #49900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48b249d
Add `useSelect` and `useSuspenseSelect` as additional hooks in exhaus…
ecgan Apr 18, 2023
5b57842
Disable eslint rule to suppress eslint error for now.
ecgan Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/components/src/mobile/link-picker/link-picker-results.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ export default function LinkPickerResults( {
return {
fetchMoreSuggestions: debounce( fetchMore, REQUEST_DEBOUNCE_DELAY ),
};
// Disable eslint rule for now, to avoid introducing a regression
// (see https://github.com/WordPress/gutenberg/pull/23922#discussion_r1170634879).
// eslint-disable-next-line react-hooks/exhaustive-deps
Comment on lines +77 to +79
Copy link
Contributor Author

@ecgan ecgan Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #23922 (comment), I have temporarily disabled eslint rule for this line to suppress eslint error for now.

Copy link
Member

@dcalhoun dcalhoun Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the linter error on mobile-specific violations has been done in the past. I think this makes sense in this case to unblock this PR. Thanks for the ping!

}, [] );

// Prevent setting state when unmounted.
Expand Down
7 changes: 6 additions & 1 deletion packages/eslint-plugin/configs/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,12 @@ module.exports = {
'react/no-children-prop': 'off',
'react/prop-types': 'off',
'react/react-in-jsx-scope': 'off',
'react-hooks/exhaustive-deps': 'warn',
'react-hooks/exhaustive-deps': [
'warn',
{
additionalHooks: '(useSelect|useSuspenseSelect)',
},
],
'react-hooks/rules-of-hooks': 'error',
},
};