Skip to content

Mention "testsPort" .wp-env.json setting#49388

Merged
noahtallen merged 1 commit intoWordPress:trunkfrom
enderandpeter:patch-1
Mar 28, 2023
Merged

Mention "testsPort" .wp-env.json setting#49388
noahtallen merged 1 commit intoWordPress:trunkfrom
enderandpeter:patch-1

Conversation

@enderandpeter
Copy link
Copy Markdown
Contributor

What?

Mentions the testsPort option for .wp-env.json in the table that lists this file's options, consistent with this page referring to the option further down. Also, more than six options appear to be supported, so that wording was changed.

Why?

Provides more clarity on how to use this tool. Creating an env section is an available choice, but setting testsPort is more straightforward for when you just want to change that and create a new wp-env that does not interfere with another.

How?

This PR will simply make mention of testsPort similarly to how other options are summarized.

Testing Instructions

  1. Create a new wp-env environment, but set testsPort port in the .wp-env.json to a value other than 8889.
  2. Confirm that the wp-env test instance is using the specified port.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

image

* The `.wp-env.json` also supports setting `testsPort` for the test port, in addition to `env.tests.port`.
* This file appears to now support more than six options
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 28, 2023
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @enderandpeter! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@noahtallen noahtallen merged commit 59deab9 into WordPress:trunk Mar 28, 2023
@github-actions
Copy link
Copy Markdown

Congratulations on your first merged pull request, @enderandpeter! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 28, 2023
@enderandpeter
Copy link
Copy Markdown
Contributor Author

Thanks!

@ryanwelcher ryanwelcher added [Type] Developer Documentation Documentation for developers [Tool] Env /packages/env labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Tool] Env /packages/env [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants