Fix/editor-sidebar-animation#48628
Closed
Conversation
…of padding-bottom hack
…ring edit view We currently have a bit of a mismatch in terms of animation when you move between browsing / editing The Site Icon and Save button remain in place, but the menu items (very quickly) slide away to the left. Ideally everything in the dark sidebar should remain stationary, solidifying the idea that the frame sits "on top" of everything else. Props jameskoster Fixes #48595
ghost
requested a review
from
Author
|
Accidentally created the branch while still on a branch for another PR, reverted those changes but you can cherry pick this commit, it's the only one that makes changes for this animation Site Editor: dark sidebar contents should remain stationary when ente… |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We currently have a bit of a mismatch in terms of animation when you move between browsing / editing
Why?
The Site Icon and Save button remain in place, but the menu items (very quickly) slide away to the left. Ideally everything in the dark sidebar should remain stationary, solidifying the idea that the frame sits "on top" of everything else.
How?
Removed the animation on the x axis.
Testing Instructions
Props jameskoster
Fixes #48595