Repository navigation
Migrate query test to Playwright - #47995
Merged
Merged
Conversation
kevin940726
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in d65d318. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4164730243
|
WunderBart
approved these changes
Feb 13, 2023
WunderBart
left a comment
WunderBart
left a comment
Member
There was a problem hiding this comment.
Just one comment. Otherwise, it looks great! Thanks! 🚀
kevin940726
force-pushed
the
migrate/playwright-query
branch
from
February 13, 2023 14:57
ab50bef to
d65d318
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Part of #38851. Hopefully fixes #47632. Based on #43763 by @pavanpatil1.
How?
Judging from the failure artifacts in #47632, it seems like the test sometimes fails to select the correct query pattern. This could be related to layout shifting in the modal. Playwright automatically checks for actionability when clicking, so hopefully migrating it to Playwright fixes the issue.
Testing Instructions
CI should pass.