Skip to content

[block-library] Adds support for border-control to Quote Block#47521

Closed
Pathan-Amaankhan wants to merge 4 commits intoWordPress:trunkfrom
Pathan-Amaankhan:add/support-for-border-in-quote-block
Closed

[block-library] Adds support for border-control to Quote Block#47521
Pathan-Amaankhan wants to merge 4 commits intoWordPress:trunkfrom
Pathan-Amaankhan:add/support-for-border-in-quote-block

Conversation

@Pathan-Amaankhan
Copy link
Copy Markdown

@Pathan-Amaankhan Pathan-Amaankhan commented Jan 28, 2023

What?

  • This PR adds support for border-control to Quote Block.
  • Due to this users can add custom borders to the quote blocks.

Why?

  • As per the discussion done here, as we are not adding support for the wp-block-styles in TT3(twentytwenty-three) theme, we are missing border styles in our quote block.
  • So, to resolve this we have decided to add border-control support in our Quote Block. (Please view comment-1 & comment-2 for more information)

How?

  • We are adding border-control support to our quote block.
  • This way the users will be free to set the border as per their requirements.

Testing Instructions

  1. Open a Post or Page in Edit Mode.
  2. Insert a Quote Block.
  3. We will be having a Border option in Block Settings from where we can update the following border options:
    • color
    • radius
    • style
    • width

Screenshots or screencast

Before After
Screenshot 2023-01-28 at 3 38 05 PM Screenshot 2023-01-28 at 3 32 38 PM

Fixes / Closes Issue:

Track ticket: https://core.trac.wordpress.org/ticket/57506

@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Pathan-Amaankhan! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 28, 2023
@Pathan-Amaankhan Pathan-Amaankhan marked this pull request as ready for review January 28, 2023 10:34
@Pathan-Amaankhan Pathan-Amaankhan marked this pull request as draft January 28, 2023 10:55
@Pathan-Amaankhan Pathan-Amaankhan deleted the add/support-for-border-in-quote-block branch January 30, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant