Shadow: rename shadow palette to presets#47272
Merged
Conversation
madhusudhand
requested review from
ajitbohra,
ajlende,
fabiankaegy,
juanmaguitar,
ryanwelcher and
spacedmonkey
as code owners
|
Flaky tests detected in c39a2a5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3957013612
|
This was referenced Jan 25, 2023
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 1, 2023
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by * Adding it to presets metadata and valid settings. * Defining the default shadow presets in Core's `theme.json`. Includes PHPUnit tests. References: * [WordPress/gutenberg#46813 Gutenberg PR 46813] * [WordPress/gutenberg#47272 Gutenberg PR 47272] Follow-up to [54162], [52049], [50973]. Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya. Fixes #57559. git-svn-id: https://develop.svn.wordpress.org/trunk@55176 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 1, 2023
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by * Adding it to presets metadata and valid settings. * Defining the default shadow presets in Core's `theme.json`. Includes PHPUnit tests. References: * [WordPress/gutenberg#46813 Gutenberg PR 46813] * [WordPress/gutenberg#47272 Gutenberg PR 47272] Follow-up to [54162], [52049], [50973]. Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya. Fixes #57559. Built from https://develop.svn.wordpress.org/trunk@55176 git-svn-id: http://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Feb 1, 2023
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by * Adding it to presets metadata and valid settings. * Defining the default shadow presets in Core's `theme.json`. Includes PHPUnit tests. References: * [WordPress/gutenberg#46813 Gutenberg PR 46813] * [WordPress/gutenberg#47272 Gutenberg PR 47272] Follow-up to [54162], [52049], [50973]. Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya. Fixes #57559. Built from https://develop.svn.wordpress.org/trunk@55176 git-svn-id: https://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
VenusPR
pushed a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by * Adding it to presets metadata and valid settings. * Defining the default shadow presets in Core's `theme.json`. Includes PHPUnit tests. References: * [WordPress/gutenberg#46813 Gutenberg PR 46813] * [WordPress/gutenberg#47272 Gutenberg PR 47272] Follow-up to [54162], [52049], [50973]. Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya. Fixes #57559. Built from https://develop.svn.wordpress.org/trunk@55176 git-svn-id: http://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Rename
shadow => palettetoshadow => presetsto give more meaning.It has no effect from previous behavior.
The new definition of the shadow presets changes to