Skip to content

Global Styles: Save and Delete functionality for user variations #46952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Global Styles: Save and Delete functionality for user variations #46952

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
15c9e21
WIP: Saving custom variations
ribaricplusplus Jan 8, 2023
a1bd05d
WIP: Saving custom variations
ribaricplusplus Jan 8, 2023
cb0a333
WIP: Saving styles
ribaricplusplus Jan 9, 2023
854a80f
WIP: Saving styles
ribaricplusplus Jan 10, 2023
fe7805d
WIP: Saving styles
ribaricplusplus Jan 10, 2023
b4278d2
Fix unit test
ribaricplusplus Jan 10, 2023
3553b3b
WIP: Saving styles
ribaricplusplus Jan 10, 2023
d40d298
Add unit test
ribaricplusplus Jan 10, 2023
988ca70
Add unit test
ribaricplusplus Jan 10, 2023
da5a0e0
WIP: Saving styles
ribaricplusplus Jan 10, 2023
975326c
WIP: Saving styles
ribaricplusplus Jan 10, 2023
b3b1c6d
Add e2e tests
ribaricplusplus Jan 11, 2023
da15655
Global styles variations PHP changes
ribaricplusplus Jan 11, 2023
ce56414
Merge branch 'rpp-php-changes' into ribaricplusplus
ribaricplusplus Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP: Saving custom variations
  • Loading branch information
@ribaricplusplus
ribaricplusplus committed Jan 8, 2023
commit a1bd05d6f7b0ccf1f1f9d5c1200ebdffcf174011
9 changes: 6 additions & 3 deletions packages/edit-site/src/components/global-styles/global-styles-provider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ const cleanEmptyObject = ( object ) => {
};

function useGlobalStylesUserConfig() {
const { hasFinishedResolution } = useSelect( coreStore );
const {
hasFinishedResolution,
__experimentalHasAssociatedVariationChanged,
} = useSelect( coreStore );
const { editEntityRecord, __experimentalAssociatedVariationChanged } =
useDispatch( coreStore );

Expand All @@ -68,7 +71,7 @@ function useGlobalStylesUserConfig() {
: undefined;
if (
_associatedStyleId &&
! __experimentalAssociatedVariationChanged()
! __experimentalHasAssociatedVariationChanged()
) {
getEditedEntityRecord(
'root',
Expand Down Expand Up @@ -98,7 +101,7 @@ function useGlobalStylesUserConfig() {
}

const associatedStyleFinishedResolution =
__experimentalAssociatedVariationChanged() ||
__experimentalHasAssociatedVariationChanged() ||
hasFinishedResolution( 'getEditedEntityRecord', [
'root',
'globalStyles',
Expand Down